Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log): fix log axis breaks a single data whose log value is negative #17322

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Jul 5, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

When the log axis contains only one data and its value is less than 1, echarts fail to render. This PR fixes this problem.

Fixed issues

#13154

Details

Before: What was the problem?

chart.setOption({
    xAxis: {
        type: 'value',
    },
    yAxis: {
        type: 'log',
        logBase: 2,
    },
    series: [
        {
            type: 'scatter',
            itemStyle: {
                color: 'red',
            },
            data: [
                [1, .5],
            ],
        },
    ],
});

image

After: How does it behave after the fixing?

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jul 5, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@Ovilia Ovilia added this to the 5.4 milestone Jul 5, 2022
src/scale/Log.ts Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jul 6, 2022
@Ovilia Ovilia requested a review from plainheart August 8, 2022 09:49
@plainheart plainheart merged commit 62ebcb9 into master Aug 9, 2022
@echarts-bot
Copy link

echarts-bot bot commented Aug 9, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the fix-13154 branch August 9, 2022 04:28
@plainheart plainheart linked an issue Aug 9, 2022 that may be closed by this pull request
@Ovilia Ovilia modified the milestones: 5.4, 5.4.0 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scatter chart not rendering with log axis
2 participants