Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LineDraw):series-lines support the effect animation go back #16943

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

wangguisong
Copy link

@wangguisong wangguisong commented Apr 26, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

add the effect.goback property in series-lines to enable the effect animation can go back to the starting point after reaching the destination. it`s necessary to indicates a round trip flight.

Fixed issues

Details

Before: What was the problem?

the effect animation in series-lines is one-way, can not indicates a round trip flight.

one-way

After: How is it fixed in this PR?

add the effect.goback property in series-lines to enable the effect animation can go back

goback

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Apr 26, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@pissang pissang modified the milestones: 5.3.3, 5.4 Apr 26, 2022
@pissang pissang changed the base branch from master to next April 26, 2022 07:08
@pissang
Copy link
Contributor

pissang commented Apr 26, 2022

Wow looks great! Could we rename the option from goback to roundTrip to be more meaningful?

@pissang pissang changed the base branch from next to master April 26, 2022 07:16
@pissang pissang changed the base branch from master to next April 26, 2022 07:17
@wangguisong
Copy link
Author

Wow looks great! Could we rename the option from goback to roundTrip to be more meaningful?

yes, of cause

@pissang pissang changed the base branch from next to master April 26, 2022 07:23
@pissang pissang changed the base branch from master to next April 26, 2022 07:23
@pissang pissang merged commit 0fa933d into apache:next Apr 27, 2022
@echarts-bot
Copy link

echarts-bot bot commented Apr 27, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart added the PR: awaiting doc Document changes is required for this PR. label May 3, 2022
@Ovilia Ovilia removed this from the 5.4 milestone Sep 1, 2022
@Ovilia Ovilia added this to the 5.4.0 milestone Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: awaiting doc Document changes is required for this PR. PR: first-time contributor size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants