Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pie-label):#16208 When the total number of data is less than or equal to 2, the first data label shows a bug #16229

Merged
merged 4 commits into from
Dec 21, 2021
Merged

fix(pie-label):#16208 When the total number of data is less than or equal to 2, the first data label shows a bug #16229

merged 4 commits into from
Dec 21, 2021

Conversation

116050423
Copy link
Contributor

@116050423 116050423 commented Dec 15, 2021 •
edited by pissang
Loading

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed issues

Details

Before: What was the problem?

After: How is it fixed in this PR?

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Dec 15, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@116050423 116050423 changed the title fix(pie-label):#16208 饼图当数据总数小于等于2时，首项数据label显示有bug fix(pie-label):#16208 When the total number of data is less than or equal to 2, the first data label shows a bug Dec 15, 2021
@116050423
Copy link
Contributor Author

@pissang @Ovilia Hi, I passed the local test + visual test, would you please help to review my code, thanks.

@susiwen8
Copy link
Contributor

Could you add a test case for it?

@116050423
fix(pie-label):apache#16208 When the total number of data is less tha…
5d799bc 
…n or equal to 2, the first data label shows a bug
@susiwen8 susiwen8 requested a review from pissang December 16, 2021 06:44
@116050423
fix(pie-label):apache#16208 When the total number of data is less tha…
aee8290 
…n or equal to 2, the first data label shows a bug
@116050423
Copy link
Contributor Author

test case added, please help to review, thanks

pissang
pissang reviewed Dec 17, 2021
View reviewed changes
test/pie-label.html Outdated Show resolved Hide resolved
@116050423
fix(pie-label):apache#16208 When the total number of data is less tha…
43532df 
…n or equal to 2, the first data label shows a bug
@plainheart plainheart linked an issue Dec 20, 2021 that may be closed by this pull request
[Bug] ECharts 饼图当数据总数小于等于2时，首项数据label显示有bug #16208
Closed
@pissang pissang added this to the 5.3 milestone Dec 21, 2021
@pissang pissang merged commit 566ba8e into apache:master Dec 21, 2021
@echarts-bot
Copy link

echarts-bot bot commented Dec 21, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pissang pissang pissang approved these changes

Assignees
No one assigned
Labels
PR: first-time contributor size/XS
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.

[Bug] ECharts 饼图当数据总数小于等于2时，首项数据label显示有bug
3 participants
@116050423 @susiwen8 @pissang