Skip to content

Commit

Permalink
feat: rename variables
Browse files Browse the repository at this point in the history
  • Loading branch information
Ovilia committed May 26, 2022
1 parent 4b2bd9c commit c11463a
Show file tree
Hide file tree
Showing 7 changed files with 28 additions and 22 deletions.
2 changes: 1 addition & 1 deletion src/chart/bar/BarView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1146,7 +1146,7 @@ function createLarge(
const el = new LargePath({
shape: {points: data.getLayout('largePoints')},
incremental: !!incremental,
ignoreTargetSize: true,
ignoreCoarsePointer: true,
z2: 1
});
el.baseDimIdx = baseDimIdx;
Expand Down
4 changes: 2 additions & 2 deletions src/chart/candlestick/CandlestickView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -359,13 +359,13 @@ function createLarge(
const elP = new LargeBoxPath({
shape: {points: largePoints},
__sign: 1,
ignoreTargetSize: true
ignoreCoarsePointer: true
});
group.add(elP);
const elN = new LargeBoxPath({
shape: {points: largePoints},
__sign: -1,
ignoreTargetSize: true
ignoreCoarsePointer: true
});
group.add(elN);

Expand Down
2 changes: 1 addition & 1 deletion src/chart/helper/LargeLineDraw.ts
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ class LargeLineDraw {
private _create() {
const lineEl = new LargeLinesPath({
cursor: 'default',
ignoreTargetSize: true
ignoreCoarsePointer: true
});
this._newAdded.push(lineEl);
this.group.add(lineEl);
Expand Down
2 changes: 1 addition & 1 deletion src/chart/helper/LargeSymbolDraw.ts
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ class LargeSymbolDraw {
const symbolEl = new LargeSymbolPath({
cursor: 'default'
});
symbolEl.ignoreTargetSize = true;
symbolEl.ignoreCoarsePointer = true;
this.group.add(symbolEl);
this._newAdded.push(symbolEl);
return symbolEl;
Expand Down
8 changes: 4 additions & 4 deletions src/core/echarts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -324,8 +324,8 @@ type EChartsInitOpts = {
renderer?: RendererType,
devicePixelRatio?: number,
useDirtyRect?: boolean,
useTargetSize?: boolean,
targetSize?: number,
useCoarsePointer?: boolean,
pointerSize?: number,
ssr?: boolean,
width?: number,
height?: number
Expand Down Expand Up @@ -433,8 +433,8 @@ class ECharts extends Eventful<ECEventDefinition> {
height: opts.height,
ssr: opts.ssr,
useDirtyRect: opts.useDirtyRect == null ? defaultUseDirtyRect : opts.useDirtyRect,
useTargetSize: opts.useTargetSize,
targetSize: opts.targetSize
useCoarsePointer: opts.useCoarsePointer,
pointerSize: opts.pointerSize
});
this._ssr = opts.ssr;

Expand Down
8 changes: 4 additions & 4 deletions test/lib/testHelper.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 15 additions & 9 deletions test/target-size.html → test/pointer-size.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit c11463a

Please sign in to comment.