Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system properties to support allow non-serializable class #9340

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Dec 1, 2021

What is the purpose of the change

configure -Ddubbo.hessian.allowNonSerializable=true to enable allowNonSerializable for hessian-lite

Fix #9339

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Contributor

@guohao guohao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2021

Codecov Report

Merging #9340 (3b9b2ab) into 3.0 (43d46d9) will increase coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #9340      +/-   ##
============================================
+ Coverage     65.31%   65.35%   +0.03%     
- Complexity      340      341       +1     
============================================
  Files          1201     1201              
  Lines         51854    51854              
  Branches       7723     7723              
============================================
+ Hits          33870    33887      +17     
+ Misses        14369    14353      -16     
+ Partials       3615     3614       -1     
Impacted Files Coverage Δ
...an2/dubbo/WhitelistHessian2FactoryInitializer.java 0.00% <0.00%> (ø)
...sian2/dubbo/DefaultHessian2FactoryInitializer.java 100.00% <100.00%> (ø)
.../remoting/api/SingleProtocolConnectionManager.java 61.53% <0.00%> (-23.08%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 67.39% <0.00%> (-4.35%) ⬇️
...java/org/apache/dubbo/remoting/api/Connection.java 70.33% <0.00%> (-0.85%) ⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 84.87% <0.00%> (-0.35%) ⬇️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 63.28% <0.00%> (ø)
...ubbo/config/deploy/DefaultApplicationDeployer.java 73.83% <0.00%> (+0.18%) ⬆️
...ubbo/registry/client/ServiceDiscoveryRegistry.java 77.92% <0.00%> (+0.64%) ⬆️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 82.14% <0.00%> (+1.19%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43d46d9...3b9b2ab. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 72c8cba into apache:3.0 Dec 1, 2021
AlbumenJ added a commit that referenced this pull request Nov 28, 2022
HankDevelop pushed a commit to HankDevelop/dubbo that referenced this pull request Jan 1, 2023
@lexang
Copy link

lexang commented Sep 6, 2023

报错:Current mode is strict check, will disallow to deserialize it by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hessian 序列化如何不支持非Serializable 对象
4 participants