-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LFUCache]Add frequency of key and delete the empty cache queue #7967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.Add a timeout field to determine if an empty queue can be deleted
2.Add a timeout field to determine if an empty queue can be deleted 3.Add a method to get frequency of the key
2.Add a timeout field to determine if an empty queue can be deleted 3.Add a method to get frequency of the key
Codecov Report
@@ Coverage Diff @@
## master #7967 +/- ##
============================================
- Coverage 60.85% 60.84% -0.02%
+ Complexity 491 490 -1
============================================
Files 1089 1089
Lines 43877 43936 +59
Branches 6412 6420 +8
============================================
+ Hits 26703 26734 +31
- Misses 14210 14235 +25
- Partials 2964 2967 +3
Continue to review full report at Codecov.
|
AlbumenJ
approved these changes
Jun 7, 2021
zhaoguhong
added a commit
to zhaoguhong/dubbo
that referenced
this pull request
May 25, 2022
…ue (apache#7967)" This reverts commit e8581fd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
You can not get frequency of the key or delete the empty cache queue before.
Brief changelog
1.Change the freqTable from Array to TreeMap
2.Add a timeout field to determine if an empty queue can be deleted
3.Add a method to get frequency of the key
Verifying this change
Checklist