Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the bug, consistenthash loadbalance always construct new Consiste… #5440

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

CodingSinger
Copy link
Member

fix the issue #5429
only pay attention to the elements in the list not the list. using the hashcode of list instead of System.identityHashCode to compute the hash.

@codecov-io
Copy link

Codecov Report

Merging #5440 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5440      +/-   ##
============================================
- Coverage     61.21%   61.19%   -0.03%     
+ Complexity      424      422       -2     
============================================
  Files           919      919              
  Lines         37514    37514              
  Branches       5461     5461              
============================================
- Hits          22964    22955       -9     
- Misses        12046    12052       +6     
- Partials       2504     2507       +3
Impacted Files Coverage Δ Complexity Δ
...cluster/loadbalance/ConsistentHashLoadBalance.java 87.75% <100%> (ø) 0 <0> (ø) ⬇️
...pache/dubbo/remoting/transport/AbstractServer.java 53.75% <0%> (-3.75%) 0% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0%> (-3.51%) 8% <0%> (-1%)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0%> (-3.41%) 19% <0%> (-1%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 65.34% <0%> (-1%) 0% <0%> (ø)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 61.87% <0%> (-0.63%) 29% <0%> (ø)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 63.1% <0%> (-0.35%) 0% <0%> (ø)
...mmon/threadpool/support/AbortPolicyWithReport.java 89.18% <0%> (+5.4%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97e20f5...68821a1. Read the comment docs.

@chickenlj chickenlj merged commit e1480f9 into apache:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants