Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #4227 : remove duplicate @Override #4228

Merged
merged 1 commit into from
May 31, 2019
Merged

fix #4227 : remove duplicate @Override #4228

merged 1 commit into from
May 31, 2019

Conversation

wanghbxxxx
Copy link
Contributor

@wanghbxxxx wanghbxxxx commented May 31, 2019

What is the purpose of the change

fix #4227

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@wanghbxxxx wanghbxxxx changed the title remove duplicate @Override fix #4227 : remove duplicate @Override May 31, 2019
@htynkn htynkn self-requested a review May 31, 2019 11:28
@htynkn htynkn merged commit 85dd59c into master May 31, 2019
@htynkn htynkn deleted the wanghbxxxx-patch-1 branch June 1, 2019 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maven project compile error
2 participants