Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PENDING_TASKS. #4087

Closed
wants to merge 1 commit into from
Closed

Conversation

carryxyh
Copy link
Member

Remove PENDING_TASKS.

Refactor for:
#4040

Related for:
#4085

@codecov-io
Copy link

Codecov Report

Merging #4087 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #4087      +/-   ##
===========================================
+ Coverage     62.69%   62.7%   +0.01%     
  Complexity      544     544              
===========================================
  Files           762     762              
  Lines         32758   32757       -1     
  Branches       5165    5165              
===========================================
+ Hits          20538   20541       +3     
+ Misses         9861    9857       -4     
  Partials       2359    2359
Impacted Files Coverage Δ Complexity Δ
...dubbo/remoting/exchange/support/DefaultFuture.java 75% <100%> (-0.17%) 0 <0> (ø)
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (-11.37%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (ø) 0% <0%> (ø) ⬇️
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 80.88% <0%> (+0.73%) 0% <0%> (ø) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 69.68% <0%> (+1.8%) 0% <0%> (ø) ⬇️
...bo/rpc/cluster/support/FailbackClusterInvoker.java 70.49% <0%> (+3.27%) 0% <0%> (ø) ⬇️
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 69.23% <0%> (+5.12%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfb6077...b0c630f. Read the comment docs.

chickenlj added a commit to chickenlj/incubator-dubbo that referenced this pull request May 23, 2019
carryxyh pushed a commit that referenced this pull request May 23, 2019
Performance tuning for TimeoutTask in DefaultFuture, manually merge #4085 and #4087
@chickenlj chickenlj closed this May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants