Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error pr---Fluent style builder API support(#3431) #3544

Closed
wants to merge 1 commit into from
Closed

error pr---Fluent style builder API support(#3431) #3544

wants to merge 1 commit into from

Conversation

Bricks-Man
Copy link
Contributor

@Bricks-Man Bricks-Man commented Feb 22, 2019

What is the purpose of the change

Fluent style builder API support

Brief changelog

Verifying this change

see UT

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Code clean & add UT

resolve UT failure

remove unused UT
@Bricks-Man Bricks-Man closed this Feb 22, 2019
@Bricks-Man Bricks-Man deleted the fluent branch February 22, 2019 10:09
@Bricks-Man Bricks-Man changed the title Fluent style builder API support(#3431) error pr---Fluent style builder API support(#3431) Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant