Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dubbo-2063]: @Service(register=false) is not work #2071

Merged
merged 1 commit into from
Jul 12, 2018
Merged

[dubbo-2063]: @Service(register=false) is not work #2071

merged 1 commit into from
Jul 12, 2018

Conversation

beiwei30
Copy link
Member

What is the purpose of the change

issue#2063: @service(register=false) is not work

Brief changelog

dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/annotation/Service.java

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #2071 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2071      +/-   ##
============================================
+ Coverage     53.03%   53.04%   +<.01%     
- Complexity     4952     4954       +2     
============================================
  Files           559      559              
  Lines         24894    24894              
  Branches       4432     4432              
============================================
+ Hits          13202    13204       +2     
+ Misses         9668     9667       -1     
+ Partials       2024     2023       -1
Impacted Files Coverage Δ Complexity Δ
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 41.66% <0%> (-8.34%) 3% <0%> (ø)
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 8% <0%> (-1%)
...bo/remoting/transport/netty/NettyCodecAdapter.java 53.12% <0%> (-1.57%) 3% <0%> (ø)
...ache/dubbo/remoting/transport/mina/MinaClient.java 58.46% <0%> (+1.53%) 9% <0%> (+1%) ⬆️
...e/dubbo/remoting/transport/netty4/NettyServer.java 75.4% <0%> (+3.27%) 10% <0%> (+1%) ⬆️
.../dubbo/remoting/transport/netty4/NettyChannel.java 65% <0%> (+5%) 22% <0%> (+1%) ⬆️
...onfig/spring/extension/SpringExtensionFactory.java 85.71% <0%> (+7.14%) 10% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6880b2...40f57cb. Read the comment docs.

@beiwei30 beiwei30 merged commit 32b7c17 into apache:master Jul 12, 2018
@beiwei30 beiwei30 deleted the issue2063 branch July 12, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants