[Dubbo-1695] Enhance the test coverage part-16 : dubbo-rpc/dubbo-rpc-api module #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2004 +/- ##
============================================
+ Coverage 51.15% 52.16% +1.01%
- Complexity 4791 4903 +112
============================================
Files 562 562
Lines 25218 25216 -2
Branches 4449 4449
============================================
+ Hits 12900 13154 +254
+ Misses 10383 10058 -325
- Partials 1935 2004 +69
Continue to review full report at Codecov.
|
lovepoem
reviewed
Jun 29, 2018
| import org.apache.dubbo.rpc.RpcException; | ||
| import org.apache.dubbo.rpc.RpcInvocation; | ||
| import org.apache.dubbo.common.utils.StringUtils; | ||
| import org.apache.dubbo.rpc.*; |
There was a problem hiding this comment.
.* is not recommend， please use dubbo_style in your idea
lovepoem
reviewed
Jun 29, 2018
| package org.apache.dubbo.rpc.filter; | ||
|
|
||
| import org.apache.dubbo.common.URL; | ||
| import org.apache.dubbo.rpc.*; |
There was a problem hiding this comment.
.* is not recommend， please use dubbo_style in your idea
|
|
||
| import org.apache.dubbo.common.Constants; | ||
| import org.apache.dubbo.common.URL; | ||
| import org.apache.dubbo.rpc.*; |
There was a problem hiding this comment.
.* is not recommend， please use dubbo_style in your idea
|
@lovepoem ok I will fix it. |
|
Look good to me |
July-X
pushed a commit
to July-X/dubbo
that referenced
this pull request
Jul 12, 2018
* commit 'b055991b317f4e58d256721875a00c52fe415510': (271 commits) Merge pull request apache#1957, enhancements for the new async way of Dubbo. rename log file from alibaba to custom-access (apache#2057) Merge pull request apache#2049, upgrade netty4 to the latest release and make it the default option for transporter. Format style. Restore the badges in README. Polish README. Refactor README. Merge pull request apache#2047, deprecate dubbo-rpc-thrift. Merge pull request apache#2005, change maven parent from sonatype to apache. rename access log in unit test from 'alibaba' to 'alibaba.log' so that it cannot be committed by accident. (apache#2051) add test cases for injvm rpc protocol (apache#2041) add test cases for rpc thrift protocol (apache#2042) Merge pull request apache#1966, introduces dubbo metrics API module. [Dubbo- unit test class not found] fix class not found "hi" (apache#2034) add README for compatible module (apache#2019) Polish README. update README (apache#2025) [Dubbo-1695] Enhance the test coverage part-16 : dubbo-rpc/dubbo-rpc-api module (apache#2004) Merge pull request apache#1997, clienthandler in netty4 should trigger heartbeat handler. Update issue template description. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
add unit test
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.