Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.3] Getting all nacos instances without subscription #15110

Closed

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Feb 7, 2025

What is the purpose of the change?

try to fix #15107

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.88%. Comparing base (0871406) to head (bbce7eb).
Report is 9 commits behind head on 3.3.

Files with missing lines Patch % Lines
...org/apache/dubbo/registry/nacos/NacosRegistry.java 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15110      +/-   ##
============================================
- Coverage     60.75%   58.88%   -1.88%     
+ Complexity    10865       12   -10853     
============================================
  Files          1882     1883       +1     
  Lines         86009    86014       +5     
  Branches      12887    12886       -1     
============================================
- Hits          52259    50652    -1607     
- Misses        28308    29840    +1532     
- Partials       5442     5522      +80     
Flag Coverage Δ
integration-tests ?
samples-tests ?
unit-tests 58.88% <77.77%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uzong
Copy link

uzong commented Feb 10, 2025

I have been troubled by this problem for a day. It is a sporadic problem and it is very annoying. I have upgraded dubbo to 3.2.16. Is there a way to solve it?

@zrlw
Copy link
Contributor Author

zrlw commented Feb 11, 2025

I have been troubled by this problem for a day. It is a sporadic problem and it is very annoying. I have upgraded dubbo to 3.2.16. Is there a way to solve it?

we tested and it seemed that this pr could resolve our no provider problem when restarting all clients and servers at the same time.

@zrlw zrlw force-pushed the patch-subscribeEventListener4interfaceInvoker branch from c1155bb to 4528ece Compare February 12, 2025 05:32
@zrlw zrlw changed the title calling subscribEventListener prior to notifySubscriber getting all nacos instances without subscription Feb 12, 2025
@zrlw zrlw changed the title getting all nacos instances without subscription [3.3] Getting all nacos instances without subscription Feb 12, 2025
@zrlw zrlw force-pushed the patch-subscribeEventListener4interfaceInvoker branch from 4528ece to db9b2cc Compare February 12, 2025 06:46
@AlbumenJ
Copy link
Member

#15126

Close this PR. I will merge 3.2 into 3.3 later.

@AlbumenJ AlbumenJ closed this Feb 13, 2025
@AlbumenJ
Copy link
Member

#15126

Close this PR. I will merge 3.2 into 3.3 later.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants