Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zookeeper reflection type describer registrar path #15109

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented Feb 6, 2025

What is the purpose of the change?

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.74%. Comparing base (49ede4f) to head (a60cf00).
Report is 1 commits behind head on 3.3.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15109      +/-   ##
============================================
+ Coverage     60.22%   60.74%   +0.52%     
- Complexity     8879    10861    +1982     
============================================
  Files          1882     1882              
  Lines         86009    86009              
  Branches      12887    12887              
============================================
+ Hits          51800    52250     +450     
+ Misses        28697    28311     -386     
+ Partials       5512     5448      -64     
Flag Coverage Δ
integration-tests 32.99% <ø> (?)
samples-tests 29.18% <ø> (-0.01%) ⬇️
unit-tests 58.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CrazyHZM CrazyHZM merged commit 0871406 into apache:3.3 Feb 6, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants