Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove strong dep micrometer in tracing #14986

Merged
merged 8 commits into from
Feb 10, 2025
Merged

Conversation

songxiaosheng
Copy link
Member

What is the purpose of the change?

remove strong dep micrometer in tracing
fix pr: #14872

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@AlbumenJ
Copy link
Member

Please fix style check

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 60.74%. Comparing base (09d6645) to head (20ca1e0).

Files with missing lines Patch % Lines
...apache/dubbo/tracing/DubboObservationRegistry.java 0.00% 8 Missing ⚠️
...apache/dubbo/tracing/metrics/ObservationMeter.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #14986      +/-   ##
============================================
- Coverage     60.75%   60.74%   -0.01%     
- Complexity    10864    10867       +3     
============================================
  Files          1882     1883       +1     
  Lines         86009    86009              
  Branches      12887    12887              
============================================
- Hits          52251    52247       -4     
- Misses        28313    28318       +5     
+ Partials       5445     5444       -1     
Flag Coverage Δ
integration-tests 33.05% <0.00%> (+<0.01%) ⬆️
samples-tests 29.22% <0.00%> (+<0.01%) ⬆️
unit-tests 58.89% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@songxiaosheng
Copy link
Member Author

Please fix style check

fixed

@AlbumenJ
Copy link
Member

AlbumenJ commented Feb 8, 2025

Can this PR fix that issue?

@songxiaosheng
Copy link
Member Author

Can this PR fix that issue?

yes,we can lazy load micrometer class when it exists:
image

@AlbumenJ AlbumenJ merged commit da3ed53 into apache:3.3 Feb 10, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants