Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[optimize]Refactor the dubbo-demo module #14871

Merged
merged 9 commits into from
Nov 20, 2024
Merged

Conversation

heliang666s
Copy link
Contributor

What is the purpose of the change?

  1. Remove dubbo-demo-xml, dubbo-demo-annotation, dubbo-demo-generic-call and dubbo-demo-interface.
  2. Change all default protocols from dubbo to triple.
  3. Update README.md.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.19%. Comparing base (ef6e8bd) to head (0261a18).
Report is 55 commits behind head on 3.3.

Current head 0261a18 differs from pull request most recent head 2af91b4

Please upload reports for the commit 2af91b4 to get more accurate results.

Additional details and impacted files
@@              Coverage Diff              @@
##              3.3    #14871        +/-   ##
=============================================
- Coverage   37.53%     2.19%    -35.34%     
=============================================
  Files        1813     26083     +24270     
  Lines       80737   1389674   +1308937     
  Branches    12005    220210    +208205     
=============================================
+ Hits        30304     30566       +262     
- Misses      46042   1354670   +1308628     
- Partials     4391      4438        +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo-demo-native</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, it cannot be deleted, and the native ci test relies on it.

@AlbumenJ
Copy link
Member

image

@chickenlj chickenlj merged commit 7dc57a3 into apache:3.3 Nov 20, 2024
15 of 18 checks passed
@heliang666s heliang666s deleted the demo branch November 20, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants