Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize dubbo-triple-demo #14858

Merged
merged 1 commit into from
Nov 4, 2024
Merged

optimize dubbo-triple-demo #14858

merged 1 commit into from
Nov 4, 2024

Conversation

heliang666s
Copy link
Contributor

What is the purpose of the change?

Although the original demo used the proto file, the Service interface was still defined, which seems to be not very standardized, so I moved the definition of the service interface to the proto file.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@chickenlj chickenlj merged commit 5239ded into apache:3.3 Nov 4, 2024
18 checks passed
@heliang666s heliang666s deleted the demo branch November 6, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants