Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GroupVersionCondition bug & Refine rest exception message process #14480

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

oxsean
Copy link
Collaborator

@oxsean oxsean commented Jul 30, 2024

What is the purpose of the change

  1. Fix the GroupVersionCondition duplicate wrap bug.
  2. Refactor the exception message process, the user can customize exception log or not by using the ExceptionHandle extension.
  3. Add http and rest logs for easy troubleshooting.

Brief changelog

Verifying this change

Add unit tests.

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@oxsean oxsean force-pushed the rest-condition-bugfix branch 2 times, most recently from 392b6ac to 844e391 Compare July 30, 2024 16:07
Copy link

sonarcloud bot commented Jul 31, 2024

@AlbumenJ AlbumenJ merged commit 7edd5ec into apache:3.3 Jul 31, 2024
19 checks passed
@oxsean oxsean deleted the rest-condition-bugfix branch July 31, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants