Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix h2 curl error #12996

Merged
merged 2 commits into from
Sep 2, 2023
Merged

fix h2 curl error #12996

merged 2 commits into from
Sep 2, 2023

Conversation

icodening
Copy link
Contributor

What is the purpose of the change

fix h2 curl error

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

Merging #12996 (fe2af7e) into 3.3.0-beta.1-release (cfd0be3) will increase coverage by 4.07%.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##             3.3.0-beta.1-release   #12996      +/-   ##
==========================================================
+ Coverage                   63.61%   67.68%   +4.07%     
==========================================================
  Files                        1923     1789     -134     
  Lines                       75317    71947    -3370     
  Branches                    10591    10332     -259     
==========================================================
+ Hits                        47910    48700     +790     
+ Misses                      22545    18513    -4032     
+ Partials                     4862     4734     -128     

see 3712 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@chickenlj
Copy link
Contributor

Later, we should revisit the depend on protobuf-java-util. As a simple protobuf to json tool, it's mainly about which place should we put this it in.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit d596eeb into 3.3.0-beta.1-release Sep 2, 2023
23 of 26 checks passed
@chickenlj chickenlj deleted the fix_h2_curl branch September 2, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants