Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unification HTTP server side #12815

Merged
merged 7 commits into from
Aug 9, 2023
Merged

unification HTTP server side #12815

merged 7 commits into from
Aug 9, 2023

Conversation

icodening
Copy link
Contributor

@icodening icodening commented Jul 31, 2023 •
edited
Loading

What is the purpose of the change

abstract HTTP 1/2 remoting (server)

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

EarthChen
EarthChen reviewed Aug 2, 2023
View reviewed changes
...2/src/main/java/org/apache/dubbo/remoting/http12/h2/Http2ServerTransportListenerFactory.java
import org.apache.dubbo.rpc.model.FrameworkModel;

@SPI(scope = ExtensionScope.FRAMEWORK)
public interface Http2ServerTransportListenerFactory {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can h1 and h2 merge the processing of content type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i will redesign here

EarthChen
EarthChen reviewed Aug 2, 2023
View reviewed changes
...remoting-http12/src/main/java/org/apache/dubbo/remoting/http12/message/HttpMessageCodec.java
@SPI(scope = ExtensionScope.FRAMEWORK)
public interface HttpMessageCodec {

void encode(OutputStream outputStream, Object data) throws EncodeException;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this method default?

@chickenlj chickenlj changed the base branch from 3.3 to 3.3.0-beta.1-release August 9, 2023 03:18
@chickenlj chickenlj merged commit 8bfdf1e into apache:3.3.0-beta.1-release Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EarthChen EarthChen EarthChen left review comments

@AlbumenJ AlbumenJ Awaiting requested review from AlbumenJ

@chickenlj chickenlj Awaiting requested review from chickenlj

@guohao guohao Awaiting requested review from guohao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@icodening @EarthChen @chickenlj