-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for error code metrics (#12125) #12661
Conversation
@wxbty @songxiaosheng @AlbumenJ PTAL :) |
Codecov Report
@@ Coverage Diff @@
## 3.3 #12661 +/- ##
============================================
+ Coverage 68.11% 68.13% +0.02%
Complexity 6 6
============================================
Files 1706 1710 +4
Lines 70280 70344 +64
Branches 10205 10206 +1
============================================
+ Hits 47869 47927 +58
- Misses 17746 17757 +11
+ Partials 4665 4660 -5 see 36 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whether to consider using a unified event api, such as EventBus
dubbo-common doesn't import guava, I think it might be better to use a custom implementation in this simple scene |
MetricsEventBus,The rest of the metrics collection uses this uniformly |
That will import dubbo-metrics-api into dubbo-common. But later maybe we can split out metrics-event from metrics-api to solve this problem, that can be a part of dubbo-core refactor. |
This is a feature, so I have change it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
What is the purpose of the change
Add support for error code metrics.
Brief changelog