Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for error code metrics (#12125) #12661

Merged
merged 15 commits into from
Aug 9, 2023

Conversation

namelessssssssssss
Copy link
Contributor

What is the purpose of the change

Add support for error code metrics.

Brief changelog

  • ​The error code metric is sampled when log is enabled.

@namelessssssssssss
Copy link
Contributor Author

@wxbty @songxiaosheng @AlbumenJ PTAL :)

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Merging #12661 (a3a55c5) into 3.3 (04f3fe7) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.3   #12661      +/-   ##
============================================
+ Coverage     68.11%   68.13%   +0.02%     
  Complexity        6        6              
============================================
  Files          1706     1710       +4     
  Lines         70280    70344      +64     
  Branches      10205    10206       +1     
============================================
+ Hits          47869    47927      +58     
- Misses        17746    17757      +11     
+ Partials       4665     4660       -5     

see 36 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wxbty wxbty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether to consider using a unified event api, such as EventBus

@namelessssssssssss
Copy link
Contributor Author

namelessssssssssss commented Jul 7, 2023

Whether to consider using a unified event api, such as EventBus

dubbo-common doesn't import guava, I think it might be better to use a custom implementation in this simple scene

@wxbty
Copy link
Member

wxbty commented Jul 8, 2023

Whether to consider using a unified event api, such as EventBus

dubbo-common doesn't import guava, I think it might be better to use a custom implementation in this simple scene

MetricsEventBus,The rest of the metrics collection uses this uniformly

@namelessssssssssss
Copy link
Contributor Author

Whether to consider using a unified event api, such as EventBus

dubbo-common doesn't import guava, I think it might be better to use a custom implementation in this simple scene

MetricsEventBus,The rest of the metrics collection uses this uniformly

That will import dubbo-metrics-api into dubbo-common. But later maybe we can split out metrics-event from metrics-api to solve this problem, that can be a part of dubbo-core refactor.

@AlbumenJ AlbumenJ changed the base branch from 3.2 to 3.3 July 13, 2023 12:48
@AlbumenJ
Copy link
Member

This is a feature, so I have change it to 3.3

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ
Copy link
Member

AlbumenJ commented Aug 9, 2023

image

Please resolve conflicts

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

65.2% 65.2% Coverage
0.4% 0.4% Duplication

@AlbumenJ AlbumenJ merged commit 5ae875d into apache:3.3 Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants