Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix missing metrics filter & recover #12453 #12577

Merged
merged 5 commits into from
Jun 28, 2023

Conversation

conghuhu
Copy link
Contributor

@conghuhu conghuhu commented Jun 20, 2023

What is the purpose of the change

recover #12453

In the previous PR, I accidentally deleted the spi file for the metrics filter.

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@conghuhu
Copy link
Contributor Author

@AlbumenJ PTAL

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Merging #12577 (9d03755) into 3.2 (dce7b87) will decrease coverage by 0.44%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12577      +/-   ##
============================================
- Coverage     69.69%   69.25%   -0.44%     
+ Complexity      318        2     -316     
============================================
  Files          3481     1641    -1840     
  Lines        165010    67588   -97422     
  Branches      27726     9917   -17809     
============================================
- Hits         115002    46810   -68192     
+ Misses        40017    16239   -23778     
+ Partials       9991     4539    -5452     

see 1918 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ changed the base branch from 3.2 to 3.3 June 28, 2023 12:34
@AlbumenJ AlbumenJ merged commit 95207b9 into apache:3.3 Jun 28, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 25 Code Smells

42.4% 42.4% Coverage
2.1% 2.1% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants