Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add seata sentinel starter & rename tracing starter #12543

Merged
merged 4 commits into from
Jul 7, 2023

Conversation

conghuhu
Copy link
Contributor

What is the purpose of the change

Brief changelog

  • add seata & sentinel starter
  • rename tracing starter to xxx-spring-boot-starter(After PR merge, I will synchronously modify dubbo samples

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@conghuhu
Copy link
Contributor Author

@chickenlj PTAL

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

Merging #12543 (208d2a6) into 3.2 (55484cb) will decrease coverage by 0.40%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12543      +/-   ##
============================================
- Coverage     69.60%   69.21%   -0.40%     
+ Complexity      318        2     -316     
============================================
  Files          3496     1637    -1859     
  Lines        165135    67523   -97612     
  Branches      27769     9907   -17862     
============================================
- Hits         114938    46733   -68205     
+ Misses        40196    16262   -23934     
+ Partials      10001     4528    -5473     

see 1880 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj changed the base branch from 3.2 to 3.3 July 7, 2023 02:20
@chickenlj chickenlj merged commit 4b62513 into apache:3.3 Jul 7, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants