Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport of 'fix inappropriate invoke in unsubscribe retry task' #12235

Merged
merged 1 commit into from
May 7, 2023

Conversation

XIACYBING
Copy link
Contributor

@XIACYBING XIACYBING commented May 5, 2023

What is the purpose of the change

(backport of #12231 for 3.2 branch.)

fix inappropriate invoke in unsubscribe retry task

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #12235 (d19ed65) into 3.2 (c5f8ce6) will increase coverage by 2.14%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12235      +/-   ##
============================================
+ Coverage     67.39%   69.54%   +2.14%     
+ Complexity       22        2      -20     
============================================
  Files          3541     1603    -1938     
  Lines        152589    65805   -86784     
  Branches      23337     9598   -13739     
============================================
- Hits         102838    45761   -57077     
+ Misses        40151    15652   -24499     
+ Partials       9600     4392    -5208     

see 1974 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit 7f86a8c into apache:3.2 May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants