Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto detect proxy type #12232

Merged
merged 2 commits into from
May 5, 2023
Merged

auto detect proxy type #12232

merged 2 commits into from
May 5, 2023

Conversation

icodening
Copy link
Contributor

What is the purpose of the change

auto detect proxy type

Brief changelog

add marker interface. org.apache.dubbo.rpc.model.DubboStub

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

62.5% 62.5% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #12232 (3ddd577) into 3.2 (0724e94) will decrease coverage by 2.63%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12232      +/-   ##
============================================
- Coverage     69.81%   67.19%   -2.63%     
+ Complexity      129        2     -127     
============================================
  Files          3426     1736    -1690     
  Lines        160401    68997   -91404     
  Branches      26531     9855   -16676     
============================================
- Hits         111988    46360   -65628     
+ Misses        38660    18191   -20469     
+ Partials       9753     4446    -5307     

see 1989 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen EarthChen requested a review from AlbumenJ May 5, 2023 06:01
@AlbumenJ AlbumenJ merged commit c5f8ce6 into apache:3.2 May 5, 2023
@icodening icodening deleted the auto_stub branch May 5, 2023 15:41
@icodening
Copy link
Contributor Author

ref #12175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants