refactor method name

apache · Jan 15, 2019 · 1e1a5ec · 1e1a5ec
1 parent f73e8cc
commit 1e1a5ec
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/Version.java b/dubbo-common/src/main/java/org/apache/dubbo/common/Version.java
@@ -65,7 +65,7 @@ public static String getVersion() {
     }
 
     /**
-     * To check the framework release version number to decide if it's 2.7.0 or higher
+     * Check the framework release version number to decide if it's 2.7.0 or higher
      */
     public static boolean isRelease270OrHigher(String version) {
         if (StringUtils.isEmpty(version)) {
@@ -78,11 +78,11 @@ public static boolean isRelease270OrHigher(String version) {
     }
 
     /**
-     * To check the framework release version number to decide if it's 2.6.3 or higher
+     * Check the framework release version number to decide if it's 2.6.3 or higher
      *
      * Because response attachments feature is firstly introduced in 2.6.3
-     * and moreover we have no other approach to check the framework version number, so we use
-     * isSupportResponseAttachment to decide if it's v2.6.3
+     * and moreover we have no other approach to know the framework's version, so we use
+     * isSupportResponseAttachment to decide if it's v2.6.3.
      */
     public static boolean isRelease263OrHigher(String version) {
         return isSupportResponseAttachment(version);

diff --git a/dubbo-rpc/dubbo-rpc-http/src/main/java/org/apache/dubbo/rpc/protocol/http/HttpProtocol.java b/dubbo-rpc/dubbo-rpc-http/src/main/java/org/apache/dubbo/rpc/protocol/http/HttpProtocol.java
@@ -127,7 +127,7 @@ public RemoteInvocation createRemoteInvocation(MethodInvocation methodInvocation
                 } else {
                     /*
                       The customized 'com.alibaba.dubbo.rpc.protocol.http.HttpRemoteInvocation' was firstly introduced
-                      in v2.6.3. The main purpose is to support transformation of attachments in HttpProtocol:
+                      in v2.6.3. The main purpose is to support transformation of attachments in HttpProtocol, see
                       https://github.com/apache/incubator-dubbo/pull/1827. To guarantee interoperability with lower
                       versions, we need to check if the provider is v2.6.3 or higher before sending customized
                       HttpRemoteInvocation.

diff --git a/dubbo-rpc/dubbo-rpc-rmi/src/main/java/org/apache/dubbo/rpc/protocol/rmi/RmiProtocol.java b/dubbo-rpc/dubbo-rpc-rmi/src/main/java/org/apache/dubbo/rpc/protocol/rmi/RmiProtocol.java
@@ -79,7 +79,7 @@ protected <T> T doRefer(final Class<T> serviceType, final URL url) throws RpcExc
         /*
           RMI needs extra parameter since it uses customized remote invocation object
 
-          The customized RemoteInvocation was firstly introduced in v2.6.3; The package was renamed to 'org.apache.*'
+          The customized RemoteInvocation was firstly introduced in v2.6.3; The package was renamed to 'org.apache.*' since v2.7.0
           Considering the above two conditions, we need to check before sending customized RemoteInvocation:
           1. if the provider version is v2.7.0 or higher, send 'org.apache.dubbo.rpc.protocol.rmi.RmiRemoteInvocation'.
           2. if the provider version is v2.6.3 or higher, send 'com.alibaba.dubbo.rpc.protocol.rmi.RmiRemoteInvocation'.