Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix client block until timeout when provider return with PackageResponse_Exception #926

Merged
merged 22 commits into from
Dec 13, 2020

Conversation

wenxuwan
Copy link
Member

try to fix #925

dependabot bot and others added 22 commits November 9, 2020 07:51
…b.com/magiconair/properties-1.8.4

Bump github.com/magiconair/properties from 1.8.1 to 1.8.4
…b.com/prometheus/client_golang-1.8.0

Bump github.com/prometheus/client_golang from 1.1.0 to 1.8.0
…er.org/atomic-1.7.0

Bump go.uber.org/atomic from 1.6.0 to 1.7.0
…b.com/fsnotify/fsnotify-1.4.9

Bump github.com/fsnotify/fsnotify from 1.4.7 to 1.4.9
…b.com/emicklei/go-restful/v3-3.4.0

Bump github.com/emicklei/go-restful/v3 from 3.0.0 to 3.4.0
Bumps [github.com/dubbogo/gost](https://github.com/dubbogo/gost) from 1.9.2 to 1.9.5.
- [Release notes](https://github.com/dubbogo/gost/releases)
- [Commits](dubbogo/gost@v1.9.2...v1.9.5)

Signed-off-by: dependabot[bot] <[email protected]>
…b.com/dubbogo/gost-1.9.5

Bump github.com/dubbogo/gost from 1.9.2 to 1.9.5
….in/yaml.v2-2.4.0

build(deps): bump gopkg.in/yaml.v2 from 2.3.0 to 2.4.0
…b.com/mitchellh/mapstructure-1.4.0

build(deps): bump github.com/mitchellh/mapstructure from 1.3.3 to 1.4.0
@codecov-io
Copy link

Codecov Report

Merging #926 (9e0fd61) into develop (4ea5d0a) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #926      +/-   ##
===========================================
- Coverage    59.83%   59.76%   -0.07%     
===========================================
  Files          260      260              
  Lines        12854    12852       -2     
===========================================
- Hits          7691     7681      -10     
- Misses        4202     4208       +6     
- Partials       961      963       +2     
Impacted Files Coverage Δ
protocol/dubbo/impl/codec.go 39.86% <0.00%> (+0.53%) ⬆️
config_center/nacos/facade.go 79.31% <0.00%> (-10.35%) ⬇️
registry/kubernetes/registry.go 57.60% <0.00%> (-3.27%) ⬇️
config_center/nacos/client.go 65.26% <0.00%> (-2.11%) ⬇️
remoting/getty/pool.go 68.72% <0.00%> (-0.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ea5d0a...9e0fd61. Read the comment docs.

@zouyx zouyx added this to the v1.5.5 milestone Dec 11, 2020
@AlexStocks
Copy link
Contributor

@wenxuwan pls change ur pr title to let users know what this pr do when release 1.5.5

@wenxuwan wenxuwan changed the title Fix: #925 fix client block until timeout when provider return with PackageResponse_Exception Dec 11, 2020
@wenxuwan
Copy link
Member Author

@wenxuwan pls change ur pr title to let users know what this pr do when release 1.5.5

done

fangyincheng
fangyincheng previously approved these changes Dec 12, 2020
protocol/dubbo/impl/codec.go Show resolved Hide resolved
@AlexStocks AlexStocks merged commit 1f708d7 into apache:develop Dec 13, 2020
AlexStocks added a commit that referenced this pull request Apr 14, 2021
fix client block until timeout when provider return with PackageResponse_Exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants