Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Enhance DingTalk reminder information. #753

Merged
merged 15 commits into from
Sep 13, 2020

Conversation

sdttttt
Copy link
Contributor

@sdttttt sdttttt commented Sep 12, 2020

What this PR does:

The reminders of GithubActions Robots are richer.

Badge: CI

@sdttttt sdttttt changed the title CI: Perfect reminder information. [WIP] CI: Perfect reminder information. Sep 12, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2020

Codecov Report

Merging #753 into develop will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #753      +/-   ##
===========================================
- Coverage    63.33%   63.14%   -0.19%     
===========================================
  Files          244      250       +6     
  Lines        13563    13896     +333     
===========================================
+ Hits          8590     8775     +185     
- Misses        4104     4221     +117     
- Partials       869      900      +31     
Impacted Files Coverage Δ
common/url.go 62.17% <0.00%> (-0.73%) ⬇️
config_center/nacos/impl.go 74.73% <0.00%> (ø)
config_center/apollo/impl.go 80.82% <0.00%> (ø)
config_center/zookeeper/impl.go 75.24% <0.00%> (ø)
config_center/mock_dynamic_config.go 0.00% <0.00%> (ø)
config_center/dynamic_configuration.go 62.50% <0.00%> (ø)
registry/file/listener.go 0.00% <0.00%> (ø)
config_center/file/impl.go 56.34% <0.00%> (ø)
registry/file/service_discovery.go 47.86% <0.00%> (ø)
config_center/file/factory.go 80.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a40f153...1ae651c. Read the comment docs.

@sdttttt sdttttt changed the title [WIP] CI: Perfect reminder information. [WIP] CI: Enhance DingTalk reminder information. Sep 12, 2020
@sdttttt sdttttt changed the title [WIP] CI: Enhance DingTalk reminder information. CI: Enhance DingTalk reminder information. Sep 12, 2020
Copy link
Contributor

@hxmhlt hxmhlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe dingToken and secret to be let out?

@sdttttt
Copy link
Contributor Author

sdttttt commented Sep 12, 2020

Is it safe dingToken and secret to be let out?

If you want implicit strings, you need to set their environment variables in the repository's "Setting > Secrets". @hxmhlt

@watermelo watermelo self-requested a review September 12, 2020 15:26
@AlexStocks AlexStocks merged commit e84a2cf into apache:develop Sep 13, 2020
zouyx added a commit to zouyx/dubbo-go that referenced this pull request Sep 22, 2020
CI: Enhance DingTalk reminder information.
AlexStocks pushed a commit that referenced this pull request Apr 14, 2021
CI: Enhance DingTalk reminder information.
kzhan pushed a commit to kzhan/dubbo-go that referenced this pull request Jun 5, 2021
CI: Enhance DingTalk reminder information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants