Address notification batch mode #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
requested review from
zouyx,
pantianying,
hxmhlt and
Patrick0308
and removed request for
zouyx and
pantianying
AlexStocks
reviewed
Sep 7, 2020
registry/directory/directory.go
Outdated
| var oldInvokers []protocol.Invoker | ||
|
|
||
| // in batch mode, it is safe to remove since we have the complete list of events. | ||
| if events != nil && len(events) > 1 { |
There was a problem hiding this comment.
events != nil && len(events) > 1 ==> len(events) > 1
registry/protocol/protocol.go
Outdated
| @@ -242,7 +242,12 @@ func newOverrideSubscribeListener(overriderUrl *common.URL, invoker protocol.Inv | |||
| } | |||
|
|
|||
| // Notify will be triggered when a service change notification is received. | |||
| func (nl *overrideSubscribeListener) Notify(event *registry.ServiceEvent) { | |||
| func (nl *overrideSubscribeListener) Notify(events ...*registry.ServiceEvent) { | |||
| if events == nil || len(events) == 0 { | |||
There was a problem hiding this comment.
events == nil || len(events) == 0 ==> len(events) == 0
zouyx
reviewed
Sep 8, 2020
Patrick0308
approved these changes
Sep 8, 2020
AlexStocks
approved these changes
Sep 8, 2020
zouyx
approved these changes
Sep 10, 2020
Merged
zouyx
added a commit
to zouyx/dubbo-go
that referenced
this pull request
Sep 24, 2020
Address notification batch mode # Conflicts: # registry/directory/directory.go
AlexStocks
pushed a commit
that referenced
this pull request
Apr 14, 2021
Address notification batch mode # Conflicts: # registry/directory/directory.go
kzhan
pushed a commit
to kzhan/dubbo-go
that referenced
this pull request
Jun 5, 2021
Address notification batch mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Support address notification from registry center in batch mode, instead of omit from register center one by one. In this mode, we assume all events accumulated by registry center first, then registry center will notify the directory the complete list in batch mode.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: