Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: HessianCodec failed to check package header length(issue #380) #381

Merged
merged 3 commits into from
Feb 29, 2020
Merged

Fix: HessianCodec failed to check package header length(issue #380) #381

merged 3 commits into from
Feb 29, 2020

Conversation

AlexStocks
Copy link
Contributor

What this PR does:

fix issue #380

@AlexStocks AlexStocks mentioned this pull request Feb 29, 2020
Closed
Patrick0308
Patrick0308 reviewed Feb 29, 2020
View reviewed changes
Copy link
Contributor

@Patrick0308 Patrick0308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Feb 29, 2020 •
edited
Loading

Codecov Report

Merging #381 into develop will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #381      +/-   ##
===========================================
- Coverage     66.8%   66.73%   -0.08%     
===========================================
  Files          157      157              
  Lines         8239     8242       +3     
===========================================
- Hits          5504     5500       -4     
- Misses        2209     2215       +6     
- Partials       526      527       +1
Impacted Files Coverage Δ
protocol/dubbo/codec.go 72.5% <100%> (+2.22%) ⬆️
config_center/nacos/facade.go 64.7% <0%> (-8.83%) ⬇️
filter/filter_impl/hystrix_filter.go 68.64% <0%> (-3.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44edf4f...b109ee0. Read the comment docs.

fangyincheng
fangyincheng approved these changes Feb 29, 2020
View reviewed changes
Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zouyx
zouyx approved these changes Feb 29, 2020
View reviewed changes
Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks mentioned this pull request Feb 29, 2020
Closed
@zouyx zouyx merged commit af5510b into apache:develop Feb 29, 2020
@aliiohs
Copy link
Member

aliiohs commented Feb 29, 2020

LGTM

@AlexStocks AlexStocks changed the title Fix: issue #380 Fix: HessianCodec failed to check package header length(issue #380) Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patrick0308 Patrick0308 Patrick0308 left review comments

@fangyincheng fangyincheng fangyincheng approved these changes

@zouyx zouyx zouyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AlexStocks @codecov-io @aliiohs @zouyx @Patrick0308 @fangyincheng