Use Codecov #8388
Use Codecov #8388
Conversation
asdf2014
added
the
Area - Dev
Codecov Report
|
|
The earlier comment from codecov-io is from when I was testing earlier with PR comments enabled, which is no longer enabled in the latest commit of this PR. |
Upload coverage reports to Codecov. For now, having Codecov comment on PRs or enforcing a minimum coverage threshold are both disabled until the Codecov coverage reports look reliable: https://codecov.io/gh/apache/incubator-druid
|
Note to self and anyone else looking- this looks like the codecov report for this PR: https://codecov.io/gh/apache/incubator-druid/pull/8388. It's missing some views since there's no |
.travis.yml
Outdated
| @@ -115,6 +115,9 @@ matrix: | |||
| ${MAVEN_SKIP} -Dremoteresources.skip=true | |||
| - sh -c "dmesg | egrep -i '(oom|out of memory|kill process|killed).*' -C 1 || exit 0" | |||
| - free -m | |||
| after_success: &upload_java_unit_test_coverage | |||
| - ${MVN} -pl ${MAVEN_PROJECTS} jacoco:report | |||
| - travis_retry bash <(curl -s https://codecov.io/bash) -X gcov # retry in case of network error | |||
There was a problem hiding this comment.
I think that bash here will run even if curl dies with an error, even in -e mode. I'd be more comfortable if this line was split up to prevent that from happening.
|
LGTM other than the comment in #8388 (comment). |
|
Codecov for the most recent commit in this PR: https://codecov.io/github/apache/incubator-druid/commit/0956b7b4500e79e2c270afafa7f093708db15932 |
Description
Upload coverage reports to Codecov. For now, having Codecov comment on PRs or enforcing a minimum coverage threshold are both disabled until the Codecov coverage reports look reliable: https://codecov.io/gh/apache/incubator-druid
This PR has: