Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging for LZ4Factory instance type #8341

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Conversation

jon-wei
Copy link
Contributor

@jon-wei jon-wei commented Aug 19, 2019

The LZ4Factory instance used for compression can have three different implementations:

  • native
  • unsafe
  • safe

The implementation used can affect the size of compressed output, so this PR adds additional logging around the LZ4 library to show what instance is being used. The value of java.library.path is also logged, since the native instance depends on libc > 2.14 being available on that path.

This PR has:

  • been self-reviewed.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • been tested in a test Druid cluster.

@jon-wei jon-wei merged commit e2a25fb into apache:master Aug 20, 2019
jon-wei added a commit to implydata/druid-public that referenced this pull request Aug 20, 2019
@clintropolis clintropolis added this to the 0.16.0 milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants