-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch links from druid.io to druid.apache.org #7914
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits
@@ -35,8 +35,8 @@ ingestion method. | |||
| Parallel indexing | Always parallel | Parallel if firehose is splittable | Always sequential | | |||
| Supported indexing modes | Replacing mode | Both appending and replacing modes | Both appending and replacing modes | | |||
| External dependency | Hadoop (it internally submits Hadoop jobs) | No dependency | No dependency | | |||
| Supported [rollup modes](http://druid.io/docs/latest/ingestion/index.html#roll-up-modes) | Perfect rollup | Best-effort rollup | Both perfect and best-effort rollup | | |||
| Supported partitioning methods | [Both Hash-based and range partitioning](http://druid.io/docs/latest/ingestion/hadoop.html#partitioning-specification) | N/A | Hash-based partitioning (when `forceGuaranteedRollup` = true) | | |||
| Supported [rollup modes](https://druid.apache.org/docs/latest/ingestion/index.html#roll-up-modes) | Perfect rollup | Best-effort rollup | Both perfect and best-effort rollup | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this not a /docs/...
link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, good question. I just did a find and replace 🙃, will fix
| Supported [rollup modes](http://druid.io/docs/latest/ingestion/index.html#roll-up-modes) | Perfect rollup | Best-effort rollup | Both perfect and best-effort rollup | | ||
| Supported partitioning methods | [Both Hash-based and range partitioning](http://druid.io/docs/latest/ingestion/hadoop.html#partitioning-specification) | N/A | Hash-based partitioning (when `forceGuaranteedRollup` = true) | | ||
| Supported [rollup modes](https://druid.apache.org/docs/latest/ingestion/index.html#roll-up-modes) | Perfect rollup | Best-effort rollup | Both perfect and best-effort rollup | | ||
| Supported partitioning methods | [Both Hash-based and range partitioning](https://druid.apache.org/docs/latest/ingestion/hadoop.html#partitioning-specification) | N/A | Hash-based partitioning (when `forceGuaranteedRollup` = true) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
examples/bin/jconsole.sh
Outdated
@@ -18,7 +18,7 @@ | |||
# under the License. | |||
############################ | |||
# This script downloads the appropriate log4j2 jars and runs jconsole with them as plugins. | |||
# This script can be used as an example for how to connect to a druid.io instance to | |||
# This script can be used as an example for how to connect to a druid instance to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalize Druid?
web-console/src/variables.ts
Outdated
@@ -21,10 +21,10 @@ export const LEGACY_OVERLORD_CONSOLE = '/console.html'; | |||
|
|||
export const DRUID_WEBSITE = 'http://druid.io'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, travis caught this one https://travis-ci.org/apache/incubator-druid/jobs/547030885#L1745
Looking good at least for the WebConsole part |
* switch links from druid.io to druid.apache.org * fix it
* switch links from druid.io to druid.apache.org * fix it
Does not include links to
static.druid.io