Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for cluster tiering to improve query concurrency #12128

Merged
merged 15 commits into from
Jan 15, 2022

Conversation

vtlim
Copy link
Member

@vtlim vtlim commented Jan 6, 2022

This PR adds a new doc describing query laning, Historical tiering, and Broker tiering.

This PR has:

  • been self-reviewed.

docs/operations/query-concurrency.md Outdated Show resolved Hide resolved
docs/operations/query-concurrency.md Outdated Show resolved Hide resolved
docs/operations/query-concurrency.md Outdated Show resolved Hide resolved
Copy link
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're off to a great start here. I feel like the main work is to help the user understand when/why to choose one option over the other and what the benefits/pitfalls are for each.

docs/operations/query-concurrency.md Outdated Show resolved Hide resolved
docs/operations/query-concurrency.md Outdated Show resolved Hide resolved
docs/operations/query-concurrency.md Outdated Show resolved Hide resolved
docs/operations/query-concurrency.md Outdated Show resolved Hide resolved
docs/operations/query-concurrency.md Outdated Show resolved Hide resolved
docs/operations/query-concurrency.md Outdated Show resolved Hide resolved
docs/operations/query-concurrency.md Outdated Show resolved Hide resolved
docs/operations/query-concurrency.md Outdated Show resolved Hide resolved
docs/operations/query-concurrency.md Outdated Show resolved Hide resolved
docs/operations/query-concurrency.md Outdated Show resolved Hide resolved
docs/operations/mixed-workloads.md Outdated Show resolved Hide resolved
docs/operations/mixed-workloads.md Outdated Show resolved Hide resolved
docs/operations/mixed-workloads.md Outdated Show resolved Hide resolved
docs/operations/mixed-workloads.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jihoonson jihoonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @vtlim, this doc will be very useful for our users!

Copy link
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small changes for this PR, but some ideas for clarity in a future revision.

docs/operations/mixed-workloads.md Show resolved Hide resolved
docs/operations/mixed-workloads.md Outdated Show resolved Hide resolved
docs/operations/mixed-workloads.md Outdated Show resolved Hide resolved
docs/operations/mixed-workloads.md Show resolved Hide resolved
Copy link
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@asdf2014 asdf2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, thanks a lot for your contribution

@asdf2014 asdf2014 merged commit d2ac146 into apache:master Jan 15, 2022
@vtlim vtlim deleted the docs-cluster-tiering branch January 18, 2022 18:22
@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
sachinsagare pushed a commit to sachinsagare/druid that referenced this pull request Nov 7, 2022
* add new doc

* Apply suggestions from code review

Co-authored-by: Charles Smith <[email protected]>

* reorder query laning properties

* rename doc

* new name in doc header

* organize material into "service tiering" section

* text edits and update sidebars.json

* update query laning

* how queries get assigned to lanes

* add more details to intro; use more consistent terminology

* more content

* Apply suggestions from code review

Co-authored-by: Jihoon Son <[email protected]>

* Update docs/operations/mixed-workloads.md

* Apply suggestions from code review

Co-authored-by: Charles Smith <[email protected]>

* typo

Co-authored-by: Charles Smith <[email protected]>
Co-authored-by: Jihoon Son <[email protected]>
(cherry picked from commit d2ac146)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants