[fix][compaction] Rowset::end_version null pointer #9379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiguolei
reviewed
May 5, 2022
| @@ -136,7 +136,12 @@ Status Compaction::do_compaction_impl(int64_t permits) { | |||
| int64_t current_max_version; | |||
| { | |||
| std::shared_lock rdlock(_tablet->get_header_lock()); | |||
| current_max_version = _tablet->rowset_with_max_version()->end_version(); | |||
There was a problem hiding this comment.
when will rowset_with_max_version == nullptr?
There was a problem hiding this comment.
This seems to happen in two cases:
- The tablet has no rowset.
- The version of max version rowset no longer exists in the tablet.
In fact, I did not carefully analyze why it occurs. Because other tablet->rowset_with_max_version() all compare whether the return value is null, so I also compare here : )
And here current_max_version is only used to print the log, it will not affect the execution.
There was a problem hiding this comment.
- The tablet should not have rowset because when the table is created BE will add 0-1 rowset to the tablet.
- I think we should be careful with this case... Maybe should deep dive some code.
There was a problem hiding this comment.
- The tablet should not have rowset because when the table is created BE will add 0-1 rowset to the tablet.
- I think we should be careful with this case... Maybe should deep dive some code.
I agree, these two cases are not normal, maybe the tablet was deleted during compaction, or invalid?
At present this is the previous solution, there may be a better way.
yiguolei
added
approved
|
PR approved by anyone and no changes requested. |
morningman
added
dev/1.0.1-deprecated
morningman
added
dev/merged-1.0.1-deprecated
morningman
pushed a commit
that referenced
this pull request
May 16, 2022
starocean999
pushed a commit
to starocean999/incubator-doris
that referenced
this pull request
May 19, 2022
englefly
pushed a commit
to englefly/incubator-doris
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #9371
Problem Summary:
After compaction, get tablet max version rowset returns null.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...