Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](lru_cache) fix heap-use-after-free problem for lru cache #8569

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

caiconghui
Copy link
Contributor

@caiconghui caiconghui commented Mar 21, 2022

Proposed changes

Issue Number: close #8571

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@caiconghui caiconghui changed the title [fix](lru_cache) fix memory leak for lru cache [fix](lru_cache) fix heap-use-after-free problem for lru cache Mar 21, 2022
@caiconghui caiconghui added kind/fix Categorizes issue or PR as related to a bug. and removed Memory Leak labels Mar 21, 2022
@caiconghui
Copy link
Contributor Author

cc @xinyiZzz

@caiconghui caiconghui added the dev/backlog waiting to be merged in future dev branch label Mar 21, 2022
Copy link
Contributor

@weizuo93 weizuo93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Mar 21, 2022
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/backlog waiting to be merged in future dev branch kind/fix Categorizes issue or PR as related to a bug. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] lru cache ut failed
2 participants