Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch-3.0: [improve](schema-change) support nested type with varchar type to support length growing #46639 #47008

Open
wants to merge 1 commit into
base: branch-3.0
Choose a base branch
from
Open

branch-3.0: [improve](schema-change) support nested type with varchar type to support length growing #46639 #47008

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #46639

@amorynan
[improve](schema-change) support nested type with varchar type to sup…
41f22fc 
…port length growing (#46639)

The array|map|struct schema-change behavior supports moditfy to change
the length of the varchar type in the current column type.
before
```
mysql> alter table t_sc MODIFY COLUMN s struct<col:varchar(20)>;
ERROR 1105 (HY000): errCode = 2, detailMessage = Can not change struct<col:varchar(10)> to `__doris_shadow_s` struct<col:varchar(20)> NULL
```
@Thearas
Copy link
Contributor

Thearas commented Jan 15, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jan 15, 2025
@Thearas
Copy link
Contributor

Thearas commented Jan 15, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40964 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 41f22fc92f947b91901d6028aac8f4d90c0d9fcd, data reload: false

------ Round 1 ----------------------------------
q1	17587	7651	7243	7243
q2	2065	179	162	162
q3	10764	1087	1196	1087
q4	10542	760	735	735
q5	7762	2881	2851	2851
q6	239	146	146	146
q7	972	614	599	599
q8	9359	1981	1982	1981
q9	6668	6429	6409	6409
q10	7053	2278	2281	2278
q11	462	253	264	253
q12	403	203	203	203
q13	17792	2975	2987	2975
q14	246	214	208	208
q15	577	531	530	530
q16	693	630	598	598
q17	981	617	589	589
q18	7336	6658	6736	6658
q19	1386	1073	1025	1025
q20	467	203	205	203
q21	4223	3244	3297	3244
q22	1108	1015	987	987
Total cold run time: 108685 ms
Total hot run time: 40964 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7256	7222	7176	7176
q2	329	237	228	228
q3	2935	2917	2940	2917
q4	2110	1902	1820	1820
q5	5756	5799	5728	5728
q6	228	138	143	138
q7	2216	1826	1796	1796
q8	3623	3576	3506	3506
q9	8739	8907	8869	8869
q10	3556	3523	3483	3483
q11	616	491	489	489
q12	806	612	598	598
q13	10151	3213	3134	3134
q14	320	284	266	266
q15	586	533	521	521
q16	724	685	675	675
q17	1852	1633	1579	1579
q18	8253	7701	7774	7701
q19	1685	1582	1608	1582
q20	2048	1875	1863	1863
q21	5614	5349	5394	5349
q22	1158	1073	1042	1042
Total cold run time: 70561 ms
Total hot run time: 60460 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197670 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 41f22fc92f947b91901d6028aac8f4d90c0d9fcd, data reload: false

query1	1283	909	907	907
query2	6251	2155	2101	2101
query3	10957	4427	4379	4379
query4	67125	29040	23531	23531
query5	4956	473	463	463
query6	418	188	187	187
query7	5621	327	317	317
query8	312	220	228	220
query9	8924	2685	2680	2680
query10	451	282	257	257
query11	17466	15266	15862	15266
query12	150	103	105	103
query13	1531	445	430	430
query14	10525	7509	6842	6842
query15	209	195	184	184
query16	7073	490	519	490
query17	1081	609	609	609
query18	1900	333	324	324
query19	217	164	158	158
query20	123	114	117	114
query21	212	105	111	105
query22	4854	4340	4509	4340
query23	34704	34124	34421	34124
query24	6088	2936	2905	2905
query25	501	403	398	398
query26	669	183	172	172
query27	1771	361	358	358
query28	4221	2451	2427	2427
query29	682	452	443	443
query30	244	164	161	161
query31	1014	806	820	806
query32	66	58	56	56
query33	435	288	285	285
query34	902	499	554	499
query35	826	735	735	735
query36	1084	963	953	953
query37	126	73	75	73
query38	4141	4071	3984	3984
query39	1535	1464	1467	1464
query40	210	99	98	98
query41	50	47	46	46
query42	117	102	97	97
query43	542	498	510	498
query44	1208	839	849	839
query45	189	168	167	167
query46	1163	761	728	728
query47	2030	1955	1921	1921
query48	498	399	393	393
query49	732	398	415	398
query50	877	425	423	423
query51	7380	7120	7094	7094
query52	99	87	89	87
query53	255	183	183	183
query54	569	450	440	440
query55	79	76	76	76
query56	262	267	253	253
query57	1200	1088	1119	1088
query58	211	206	212	206
query59	3329	3160	2984	2984
query60	281	252	240	240
query61	115	106	108	106
query62	772	669	670	669
query63	219	188	192	188
query64	1390	669	644	644
query65	3266	3208	3206	3206
query66	718	298	304	298
query67	15670	15591	15577	15577
query68	3742	610	579	579
query69	430	263	274	263
query70	1202	1083	1119	1083
query71	351	248	256	248
query72	6254	4193	4218	4193
query73	758	352	357	352
query74	10175	8982	9101	8982
query75	3371	2661	2712	2661
query76	1853	1058	1071	1058
query77	511	294	279	279
query78	10484	9619	9691	9619
query79	1654	607	618	607
query80	900	507	427	427
query81	500	242	235	235
query82	1206	116	117	116
query83	187	151	142	142
query84	281	85	86	85
query85	886	314	309	309
query86	343	305	303	303
query87	4404	4368	4306	4306
query88	3919	2380	2342	2342
query89	414	292	296	292
query90	1998	189	187	187
query91	178	150	149	149
query92	67	49	51	49
query93	1849	554	547	547
query94	806	290	280	280
query95	362	258	261	258
query96	606	275	281	275
query97	3352	3196	3146	3146
query98	216	205	198	198
query99	1599	1307	1303	1303
Total cold run time: 318937 ms
Total hot run time: 197670 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.84 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 41f22fc92f947b91901d6028aac8f4d90c0d9fcd, data reload: false

query1	0.03	0.03	0.04
query2	0.06	0.03	0.02
query3	0.23	0.06	0.06
query4	1.63	0.10	0.11
query5	0.52	0.51	0.51
query6	1.14	0.72	0.72
query7	0.03	0.02	0.02
query8	0.05	0.03	0.03
query9	0.56	0.50	0.50
query10	0.55	0.56	0.55
query11	0.13	0.10	0.10
query12	0.14	0.11	0.12
query13	0.61	0.58	0.59
query14	2.92	3.04	3.09
query15	0.91	0.83	0.82
query16	0.37	0.36	0.39
query17	1.07	1.08	1.06
query18	0.24	0.23	0.22
query19	1.87	1.80	2.02
query20	0.01	0.01	0.02
query21	15.36	0.56	0.58
query22	2.58	2.16	1.44
query23	17.16	0.97	0.87
query24	2.98	1.58	0.92
query25	0.26	0.14	0.11
query26	0.43	0.13	0.14
query27	0.04	0.04	0.04
query28	10.34	1.11	1.08
query29	12.61	3.26	3.23
query30	0.25	0.06	0.06
query31	2.87	0.40	0.38
query32	3.24	0.46	0.46
query33	3.02	3.05	3.06
query34	17.31	4.54	4.59
query35	4.55	4.55	4.54
query36	0.70	0.48	0.48
query37	0.09	0.07	0.06
query38	0.04	0.03	0.04
query39	0.04	0.02	0.03
query40	0.17	0.13	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.27 s
Total hot run time: 32.84 s

@amorynan
Copy link
Contributor

run p0

@amorynan
Copy link
Contributor

run clould_p0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thearas @doris-robot @amorynan @dataroaring