Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [opt](jni) Modify Exception Cause Formatting in JniUtil for Better Readability #46437 #46601

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 8, 2025

Cherry-picked from #46437

…adability (#46437)

This PR modifies the formatting of exception causes in the JniUtil
class. Previously, the causes were separated by a newline (\n). Now,
they are separated by | for better readability and consistent log
formatting.
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Jan 8, 2025
@dataroaring dataroaring reopened this Jan 8, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41219 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c16526eb9006093813bc2a884f1d6adfb59d911f, data reload: false

------ Round 1 ----------------------------------
q1	17588	7544	7263	7263
q2	2068	173	174	173
q3	10548	1152	1166	1152
q4	10260	788	767	767
q5	8101	2972	2865	2865
q6	237	150	152	150
q7	992	646	612	612
q8	9455	2009	2042	2009
q9	6815	6502	6535	6502
q10	7123	2349	2366	2349
q11	481	270	283	270
q12	424	218	218	218
q13	18442	3109	3005	3005
q14	255	210	210	210
q15	568	534	530	530
q16	720	623	595	595
q17	988	551	605	551
q18	7261	6575	6635	6575
q19	1393	1055	1061	1055
q20	481	199	202	199
q21	4025	3374	3177	3177
q22	1089	992	1007	992
Total cold run time: 109314 ms
Total hot run time: 41219 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7204	7188	7322	7188
q2	332	233	230	230
q3	3133	3010	2931	2931
q4	2051	1835	1810	1810
q5	5650	5718	5669	5669
q6	233	141	143	141
q7	2212	1828	1812	1812
q8	3314	3472	3490	3472
q9	8867	8856	8849	8849
q10	3585	3573	3536	3536
q11	604	496	488	488
q12	802	582	598	582
q13	3929	3153	3166	3153
q14	309	271	277	271
q15	575	525	530	525
q16	692	699	657	657
q17	1839	1602	1566	1566
q18	8325	7705	7477	7477
q19	1648	1507	1448	1448
q20	2047	1803	1796	1796
q21	5268	5163	5161	5161
q22	1074	990	1008	990
Total cold run time: 63693 ms
Total hot run time: 59752 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191766 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c16526eb9006093813bc2a884f1d6adfb59d911f, data reload: false

query1	961	376	377	376
query2	6518	2121	2173	2121
query3	6708	219	222	219
query4	34225	23517	23427	23427
query5	4371	465	450	450
query6	284	177	182	177
query7	4626	314	315	314
query8	296	232	232	232
query9	9612	2689	2696	2689
query10	477	274	257	257
query11	18177	15147	15232	15147
query12	159	104	103	103
query13	1645	428	423	423
query14	9835	7459	7118	7118
query15	254	173	183	173
query16	8146	451	481	451
query17	1648	605	566	566
query18	2157	322	311	311
query19	370	160	156	156
query20	117	108	113	108
query21	220	101	107	101
query22	4667	4458	4175	4175
query23	34845	34214	33712	33712
query24	11730	2841	2923	2841
query25	715	410	425	410
query26	1844	174	170	170
query27	2808	351	356	351
query28	7966	2465	2441	2441
query29	1054	437	444	437
query30	333	163	170	163
query31	1024	794	795	794
query32	95	60	61	60
query33	811	303	297	297
query34	929	502	511	502
query35	886	698	701	698
query36	1123	952	983	952
query37	173	78	78	78
query38	3978	3848	3929	3848
query39	1469	1423	1462	1423
query40	289	101	101	101
query41	59	50	51	50
query42	114	100	100	100
query43	525	490	489	489
query44	1307	814	813	813
query45	185	166	173	166
query46	1119	712	693	693
query47	1973	1803	1852	1803
query48	470	373	390	373
query49	1310	421	402	402
query50	807	419	405	405
query51	7402	7111	7220	7111
query52	106	91	94	91
query53	268	184	191	184
query54	1236	479	470	470
query55	78	78	78	78
query56	290	278	230	230
query57	1271	1132	1158	1132
query58	238	206	214	206
query59	3211	3019	2936	2936
query60	296	264	262	262
query61	117	111	107	107
query62	883	685	674	674
query63	219	188	193	188
query64	5189	680	636	636
query65	3264	3208	3188	3188
query66	1426	338	316	316
query67	15989	15860	15733	15733
query68	4944	603	564	564
query69	444	258	262	258
query70	1205	1139	1144	1139
query71	420	255	246	246
query72	6399	3987	3983	3983
query73	761	350	344	344
query74	10277	8992	9079	8992
query75	3392	2639	2611	2611
query76	2866	1026	1168	1026
query77	408	268	271	268
query78	10551	9624	9768	9624
query79	1287	607	588	588
query80	929	451	428	428
query81	565	238	240	238
query82	766	125	116	116
query83	213	144	146	144
query84	238	78	77	77
query85	1299	302	286	286
query86	356	293	306	293
query87	4395	4277	4479	4277
query88	3480	2415	2368	2368
query89	409	301	294	294
query90	2080	184	183	183
query91	180	147	149	147
query92	59	49	50	49
query93	1088	565	541	541
query94	1041	301	298	298
query95	346	254	250	250
query96	603	277	286	277
query97	3304	3186	3169	3169
query98	205	203	199	199
query99	1524	1323	1281	1281
Total cold run time: 302931 ms
Total hot run time: 191766 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.34 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c16526eb9006093813bc2a884f1d6adfb59d911f, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.63	0.11	0.10
query5	0.52	0.49	0.51
query6	1.13	0.75	0.72
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.49	0.50
query10	0.56	0.57	0.56
query11	0.13	0.10	0.10
query12	0.15	0.11	0.12
query13	0.61	0.60	0.59
query14	3.02	2.89	2.95
query15	0.88	0.83	0.83
query16	0.39	0.39	0.37
query17	1.05	1.00	1.07
query18	0.23	0.21	0.21
query19	2.01	1.76	2.01
query20	0.01	0.01	0.01
query21	15.36	0.57	0.58
query22	2.85	2.68	1.86
query23	16.98	0.88	0.75
query24	2.84	1.10	0.66
query25	0.24	0.13	0.06
query26	0.44	0.14	0.14
query27	0.04	0.04	0.04
query28	11.05	1.10	1.08
query29	12.59	3.28	3.30
query30	0.25	0.06	0.06
query31	2.86	0.39	0.38
query32	3.25	0.46	0.46
query33	2.95	2.96	3.04
query34	16.90	4.50	4.43
query35	4.54	4.44	4.48
query36	0.66	0.48	0.50
query37	0.09	0.05	0.07
query38	0.04	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.57 s
Total hot run time: 32.34 s

@morningman morningman merged commit 08683cb into branch-3.0 Jan 8, 2025
22 checks passed
@github-actions github-actions bot deleted the auto-pick-46437-branch-3.0 branch January 8, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants