Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug](runtime-filter) pick #44408 #43078 #44686

Merged
merged 2 commits into from
Nov 28, 2024
Merged

[Bug](runtime-filter) pick #44408 #43078 #44686

merged 2 commits into from
Nov 28, 2024

Conversation

BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Nov 27, 2024

pick #44408 #43078

)

In ##41667 we support ignore filter
partitial, however, when sync_filter_size is turned off, the final
filter may only contain part of the data because some filters are judged
to be 'in'.
For example:
there are rf001(2 instances, in_or_bloom),rf000(2 instances, min_max),
instance_1 has 1e8 row and rf001 change to bloom, the rf000 will not
ignored
instance_2 has 1 row and rf001 change to in, the rf000 will ignored
finally, rf000 applied and make wrong result
@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt BiteTheDDDDt changed the title [Bug](runtime-filter) avoid wrong partitial ignore minmax filter (#43… [Bug](runtime-filter) pick #44408 #43078 Nov 27, 2024
@BiteTheDDDDt BiteTheDDDDt merged commit ddaaac5 into branch-2.1 Nov 28, 2024
20 of 24 checks passed
@BiteTheDDDDt BiteTheDDDDt deleted the cp_1127_2 branch December 17, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant