Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](index) Fix CREATE/DROP INDEX stmt toSql #44494

Merged
merged 1 commit into from
Nov 24, 2024
Merged

[fix](index) Fix CREATE/DROP INDEX stmt toSql #44494

merged 1 commit into from
Nov 24, 2024
+44 −0

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Nov 22, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Parsing CREATE INDEX and DROP INDEX will generate an AlterTableStmt, and the AlterTableStmt ::toSql() result is:

ALTER TABLE <table> CREATE INDEX <index>(<column>) and ALTER TABLE <table> DROP INDEX <index> ON <table>

This PR corrects the output to ALTER TABLE <table> ADD/DROP INDEX ...

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Sorry, something went wrong.

@w41ter
[fix](index) Fix CREATE/DROP INDEX to sql
Loading
Loading status checks…
21bcf91
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@w41ter
Copy link
Contributor Author

w41ter commented Nov 22, 2024

run buildall

airborne12
airborne12 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 8ddf4c7 into apache:master Nov 24, 2024
29 of 31 checks passed
@w41ter w41ter deleted the fix_create_drop_index_to_sql branch November 25, 2024 02:41
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Nov 26, 2024
@w41ter
[fix](index) Fix CREATE/DROP INDEX stmt toSql (apache#44494)
Loading
Loading status checks…
6014796 
Parsing `CREATE INDEX` and `DROP INDEX` will generate an
`AlterTableStmt`, and the `AlterTableStmt ::toSql()` result is:

`ALTER TABLE <table> CREATE INDEX <index>(<column>)` and `ALTER TABLE
<table> DROP INDEX <index> ON <table>`

This PR corrects the output to `ALTER TABLE <table> ADD/DROP INDEX ...`
@w41ter w41ter mentioned this pull request Nov 26, 2024
Merged
dataroaring pushed a commit that referenced this pull request Nov 26, 2024
@w41ter
[fix](index) Fix CREATE/DROP INDEX stmt toSql #44494 (#44584)
Loading
Loading status checks…
eef9ffd 
cherry pick from #44494
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Nov 27, 2024
@w41ter
[fix](index) Fix CREATE/DROP INDEX stmt toSql (apache#44494)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
e4fac51 
Parsing `CREATE INDEX` and `DROP INDEX` will generate an
`AlterTableStmt`, and the `AlterTableStmt ::toSql()` result is:

`ALTER TABLE <table> CREATE INDEX <index>(<column>)` and `ALTER TABLE
<table> DROP INDEX <index> ON <table>`

This PR corrects the output to `ALTER TABLE <table> ADD/DROP INDEX ...`
@w41ter w41ter mentioned this pull request Nov 27, 2024
Merged
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Nov 27, 2024
@w41ter
[fix](index) Fix CREATE/DROP INDEX stmt toSql (apache#44494)
Loading
Loading status checks…
39bb306 
Parsing `CREATE INDEX` and `DROP INDEX` will generate an
`AlterTableStmt`, and the `AlterTableStmt ::toSql()` result is:

`ALTER TABLE <table> CREATE INDEX <index>(<column>)` and `ALTER TABLE
<table> DROP INDEX <index> ON <table>`

This PR corrects the output to `ALTER TABLE <table> ADD/DROP INDEX ...`
w41ter added a commit that referenced this pull request Nov 28, 2024
@w41ter
[fix](index) Fix CREATE/DROP INDEX stmt toSql #44494 (#44661)
Loading
Loading status checks…
1a2a91a 
cherry pick from #44494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airborne12 airborne12

@dataroaring dataroaring

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@w41ter @doris-robot @airborne12 @dataroaring