Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](Variant) avoid unnecessary mem for variant extracted columns (#43567) #43620

Merged
merged 1 commit into from
Nov 11, 2024
Merged

[opt](Variant) avoid unnecessary mem for variant extracted columns (#43567) #43620

merged 1 commit into from
Nov 11, 2024

Conversation

eldenmoon
Copy link
Member

(#43567)

@eldenmoon
[opt](Variant) avoid unnecessary mem for variant extracted columns (a…
0fd9050 
…pache#43567)

_field_name_to_index and _field_id_to_index is unnecessary for variant
subcolumns, since they use column path as identifier
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@eldenmoon
Copy link
Member Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@eldenmoon eldenmoon merged commit ff6ec6c into apache:branch-3.0 Nov 11, 2024
22 of 24 checks passed
@eldenmoon eldenmoon deleted the branch-3.0-7319d84 branch November 11, 2024 13:03
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eldenmoon @doris-robot