Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt](cloud) Simplify default config file of meta-service #43381

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

gavinchou
Copy link
Contributor

@gavinchou gavinchou commented Nov 6, 2024

Remove some entries in the default doris_cloud.conf which may make users hard to understand.

Problem Summary:

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.
  • Release note

    None

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Copy link
Contributor

github-actions bot commented Nov 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@gavinchou gavinchou force-pushed the gavin-simplify-ms-config-file branch from d35018d to f4d2522 Compare November 6, 2024 13:29
@gavinchou
Copy link
Contributor Author

run buildall

@gavinchou gavinchou changed the title [opt](cloud) Simplify config file of meta-service [opt](cloud) Simplify default config file of meta-service Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Nov 6, 2024

PR approved by anyone and no changes requested.

Copy link
Collaborator

@TangSiyang2001 TangSiyang2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinchou gavinchou merged commit d42e829 into apache:master Nov 7, 2024
28 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 7, 2024
Remove some entries in the default doris_cloud.conf which may make users
hard to understand.
gavinchou added a commit to gavinchou/doris that referenced this pull request Nov 8, 2024
Remove some entries in the default doris_cloud.conf which may make users
hard to understand.
gavinchou added a commit that referenced this pull request Nov 10, 2024
…43522)

Remove some entries in the default doris_cloud.conf which may make users
hard to understand.
dataroaring pushed a commit that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants