Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](flexible partial update) Don't set default value for TOlapTableIndexSchema.unique_key_update_mode #43090

Conversation

bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Nov 1, 2024

What problem does this PR solve?

Problem Summary:

If we explicitly set default value for field unique_key_update_mode in .thirft file, __isset.unique_key_update_mode will always be true. So OlapTableSchemaParam::init_unique_key_update_mode will fail to set _unique_key_update_mode correctly if it receive a request from old version FE.

Check List (For Committer)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason : has been tested in rolling upgrade env
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.
  • Release note

    None

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Nov 1, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

PR approved by anyone and no changes requested.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1
Copy link
Contributor Author

bobhan1 commented Nov 2, 2024

run buildall

@zhannngchen
Copy link
Contributor

If there is no test, plz explain why in your PR description.

@bobhan1 bobhan1 force-pushed the do-not-set-default-value-for-unique-key-update-mode branch from a62d1f9 to 425ff37 Compare November 5, 2024 03:02
@bobhan1
Copy link
Contributor Author

bobhan1 commented Nov 5, 2024

run buildall

Copy link
Contributor

github-actions bot commented Nov 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

@zhannngchen zhannngchen merged commit 699509d into apache:master Nov 6, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants