Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](hive)fix hive catalog miss partition that have special characters. #42906

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

hubgeter
Copy link
Contributor

@hubgeter hubgeter commented Oct 30, 2024

Proposed changes

Previously, when processing partition values, Hive catalog parsed them in the URL format. However, this is different from the encoding method of Hive, which results in missing some partitions with special characters when reading the partition table.
This PR is to fix this problem.
Ref: common/src/java/org/apache/hadoop/hive/common/FileUtils.java:makePartName(List<String> partCols, List<String> vals,String defaultStr)

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@hubgeter
Copy link
Contributor Author

run buildall

@hubgeter
Copy link
Contributor Author

run buildall

@hubgeter hubgeter marked this pull request as ready for review October 30, 2024 11:22
@morningman
Copy link
Contributor

run buildall

@hubgeter
Copy link
Contributor Author

run buildall

@hubgeter
Copy link
Contributor Author

run buildall

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 31, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit 03c625f into apache:master Nov 1, 2024
25 of 27 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 1, 2024
…rs. (#42906)

## Proposed changes
Previously, when processing partition values, Hive catalog parsed them
in the URL format. However, this is different from the encoding method
of Hive, which results in missing some partitions with special
characters when reading the partition table.
This PR is to fix this problem.
Ref:
common/src/java/org/apache/hadoop/hive/common/FileUtils.java:`makePartName(List<String>
partCols, List<String> vals,String defaultStr)`
morningman pushed a commit to morningman/doris that referenced this pull request Nov 6, 2024
…rs. (apache#42906)

## Proposed changes
Previously, when processing partition values, Hive catalog parsed them
in the URL format. However, this is different from the encoding method
of Hive, which results in missing some partitions with special
characters when reading the partition table.
This PR is to fix this problem.
Ref:
common/src/java/org/apache/hadoop/hive/common/FileUtils.java:`makePartName(List<String>
partCols, List<String> vals,String defaultStr)`
morningman added a commit that referenced this pull request Nov 6, 2024
dataroaring pushed a commit that referenced this pull request Nov 7, 2024
…ial characters. (#43070)

PR Body: ## Proposed changes
Previously, when processing partition values, Hive catalog parsed them
in the URL format. However, this is different from the encoding method
of Hive, which results in missing some partitions with special
characters when reading the partition table.
This PR is to fix this problem.
Ref:
common/src/java/org/apache/hadoop/hive/common/FileUtils.java:`makePartName(List<String>
partCols, List<String> vals,String defaultStr)`

 
 Cherry-picked from #42906

Co-authored-by: daidai <[email protected]>
Co-authored-by: Calvin Kirs <[email protected]>
morningman pushed a commit to morningman/doris that referenced this pull request Nov 18, 2024
…rs. (apache#42906)

## Proposed changes
Previously, when processing partition values, Hive catalog parsed them
in the URL format. However, this is different from the encoding method
of Hive, which results in missing some partitions with special
characters when reading the partition table.
This PR is to fix this problem.
Ref:
common/src/java/org/apache/hadoop/hive/common/FileUtils.java:`makePartName(List<String>
partCols, List<String> vals,String defaultStr)`
morningman added a commit that referenced this pull request Nov 21, 2024
@yiguolei yiguolei mentioned this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.3-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants