Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-2.1](pick) pick 5 commits #41713

Closed
wants to merge 5 commits into from

Conversation

Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Oct 11, 2024

Proposed changes

pick #41292 #41350 #41555 #41589 #41592

apache#41292)

Consider 3 pipelines in this fragment (... -> join -> shuffle) :
pipeline 0 : `... -> local exchange sink`
pipeline 1 : `... -> join build (INNER JOIN)`
pipeline 2 : `local exchange source -> join probe (INNER JOIN) -> data
stream sender `

Assume the JoinBuild returned 0 rows, join probe can finish directly
once join build finished and do not need to wait for the `local exchange
sink` finished. In this case, if pipeline 0 is blocked by a dependency
for a long time, pipeline 2 should notify pipeline 0 to finish.
…e#41555)

For plan `local exchange (hash shuffle) -> union -> colocated agg`, we
must ensure local exchange use the same hash algorithm as MPP shuffling.

This problem is covered by our test cases but only can be reproduced on
multiple BEs so no case is added in this PR.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Gabriel39
Copy link
Contributor Author

run buildall

@Gabriel39 Gabriel39 changed the title Pick 1011 [branch-2.1](pick) pick 5 commits Oct 11, 2024
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.02% (9339/25926)
Line Coverage: 27.60% (76699/277879)
Region Coverage: 26.41% (39397/149193)
Branch Coverage: 23.20% (20049/86430)
Coverage Report: http://coverage.selectdb-in.cc/coverage/89a022e22fbe082041ed95cb166de07561adb6b8_89a022e22fbe082041ed95cb166de07561adb6b8/report/index.html

@Gabriel39 Gabriel39 closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants