Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature](array_agg) support array_agg with param is array/map/struct… #41651

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

amorynan
Copy link
Contributor

… (#40697)

this pr we support array_agg function support param with array map struct type

Proposed changes

Issue Number: close #xxx

…apache#40697)

this pr we support array_agg function support param with array map
struct type
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@amorynan
Copy link
Contributor Author

run buildall

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

using Self = AggregateFunctionArrayAggData<void>;
MutableColumnPtr column_data;

AggregateFunctionArrayAggData() {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]

Suggested change
AggregateFunctionArrayAggData() {}
AggregateFunctionArrayAggData() = default;

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.08% (9340/25886)
Line Coverage: 27.66% (76730/277406)
Region Coverage: 26.45% (39391/148931)
Branch Coverage: 23.24% (20042/86250)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c619261f2eacf5985aa2a5062bde1661569359e2_c619261f2eacf5985aa2a5062bde1661569359e2/report/index.html

@yiguolei yiguolei merged commit 1db0aef into apache:branch-2.1 Oct 10, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants