Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ubsan](PODArray)Avoid applying non-zero offset to null pointer #41525

Merged
merged 2 commits into from
Oct 9, 2024
Merged

[ubsan](PODArray)Avoid applying non-zero offset to null pointer #41525

merged 2 commits into from
Oct 9, 2024

Conversation

Mryange
Copy link
Contributor

@Mryange Mryange commented Oct 6, 2024 •
edited
Loading

Proposed changes

The original code would generate a null c_end when there is no padding.
before

    static constexpr char* null =
            pad_left ? const_cast<char*>(empty_pod_array) + EmptyPODArraySize : nullptr;

now

    static constexpr char* null = const_cast<char*>(empty_pod_array) + pad_left;

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Mryange
Copy link
Contributor Author

Mryange commented Oct 6, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.32% (9631/25805)
Line Coverage: 28.71% (79899/278281)
Region Coverage: 28.14% (41295/146753)
Branch Coverage: 24.76% (21040/84970)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7b994e6f864778f0291485f80081aed281a320c7_7b994e6f864778f0291485f80081aed281a320c7/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 40934 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7b994e6f864778f0291485f80081aed281a320c7, data reload: false

------ Round 1 ----------------------------------
q1	17903	7682	7302	7302
q2	2038	284	281	281
q3	12151	1072	1209	1072
q4	10464	752	755	752
q5	7746	2857	2884	2857
q6	238	145	146	145
q7	1056	621	616	616
q8	9349	1988	1890	1890
q9	6613	6436	6411	6411
q10	6991	2279	2319	2279
q11	447	240	249	240
q12	408	219	214	214
q13	17766	2995	2968	2968
q14	246	216	206	206
q15	558	521	530	521
q16	645	585	598	585
q17	974	577	632	577
q18	7407	6692	6639	6639
q19	1355	1009	965	965
q20	490	205	198	198
q21	3966	3217	3364	3217
q22	1116	999	1017	999
Total cold run time: 109927 ms
Total hot run time: 40934 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7270	7271	7266	7266
q2	326	233	223	223
q3	3058	2967	2911	2911
q4	2136	1891	1821	1821
q5	5787	5787	5753	5753
q6	239	142	143	142
q7	2317	1855	1817	1817
q8	3386	3554	3432	3432
q9	8899	8862	8849	8849
q10	3581	3587	3517	3517
q11	600	495	500	495
q12	825	649	620	620
q13	9217	3141	3130	3130
q14	327	264	282	264
q15	576	524	521	521
q16	687	663	652	652
q17	1876	1638	1621	1621
q18	8258	7771	7568	7568
q19	1714	1564	1586	1564
q20	2096	1870	1895	1870
q21	5627	5428	5358	5358
q22	1131	1063	1064	1063
Total cold run time: 69933 ms
Total hot run time: 60457 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191814 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7b994e6f864778f0291485f80081aed281a320c7, data reload: false

query1	918	393	402	393
query2	6227	2032	2082	2032
query3	8685	197	199	197
query4	33711	23486	23365	23365
query5	3512	466	463	463
query6	274	173	170	170
query7	4193	307	306	306
query8	293	222	222	222
query9	9764	2675	2671	2671
query10	464	289	286	286
query11	17958	15431	15211	15211
query12	152	100	97	97
query13	1575	472	423	423
query14	9300	7434	6921	6921
query15	243	168	172	168
query16	7332	455	484	455
query17	1695	637	595	595
query18	2091	328	325	325
query19	380	163	152	152
query20	118	117	115	115
query21	214	107	106	106
query22	4856	4703	4481	4481
query23	34916	34012	34122	34012
query24	11022	2864	2867	2864
query25	652	416	408	408
query26	1329	160	164	160
query27	2578	296	304	296
query28	7713	2423	2407	2407
query29	879	444	426	426
query30	255	148	155	148
query31	1030	797	806	797
query32	102	56	54	54
query33	764	309	288	288
query34	907	494	502	494
query35	858	739	721	721
query36	1088	954	965	954
query37	160	91	89	89
query38	3998	3950	3939	3939
query39	1446	1411	1464	1411
query40	262	99	99	99
query41	48	45	45	45
query42	111	93	95	93
query43	545	483	494	483
query44	1263	804	806	804
query45	197	162	167	162
query46	1123	719	717	717
query47	1990	1876	1883	1876
query48	454	354	345	345
query49	922	408	413	408
query50	863	404	413	404
query51	7041	7083	7056	7056
query52	101	86	84	84
query53	254	177	173	173
query54	1235	466	476	466
query55	78	76	77	76
query56	275	263	277	263
query57	1305	1169	1179	1169
query58	238	239	264	239
query59	3145	3019	2913	2913
query60	289	266	272	266
query61	106	99	107	99
query62	868	646	666	646
query63	216	182	186	182
query64	4958	658	611	611
query65	3296	3251	3201	3201
query66	1397	335	296	296
query67	15935	15502	15584	15502
query68	4395	561	544	544
query69	459	295	297	295
query70	1193	1085	1138	1085
query71	362	271	265	265
query72	7061	4106	3955	3955
query73	763	356	351	351
query74	10249	8987	8962	8962
query75	3400	2736	2653	2653
query76	2691	945	903	903
query77	554	303	286	286
query78	10644	9665	9922	9665
query79	2630	604	609	604
query80	976	443	440	440
query81	573	245	244	244
query82	702	140	135	135
query83	312	138	133	133
query84	278	77	76	76
query85	1449	292	296	292
query86	438	283	298	283
query87	4481	4313	4328	4313
query88	3465	2464	2442	2442
query89	408	289	286	286
query90	1975	196	183	183
query91	133	109	109	109
query92	63	50	46	46
query93	2341	546	538	538
query94	1044	305	304	304
query95	374	251	245	245
query96	611	283	280	280
query97	3238	3126	3163	3126
query98	221	198	196	196
query99	1506	1275	1318	1275
Total cold run time: 301156 ms
Total hot run time: 191814 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.04 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7b994e6f864778f0291485f80081aed281a320c7, data reload: false

query1	0.05	0.04	0.04
query2	0.06	0.03	0.03
query3	0.23	0.06	0.07
query4	1.63	0.10	0.10
query5	0.51	0.51	0.51
query6	1.13	0.73	0.74
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.55	0.50	0.49
query10	0.55	0.57	0.55
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	2.87	2.84	2.87
query15	0.90	0.82	0.82
query16	0.39	0.37	0.38
query17	1.07	1.00	1.08
query18	0.21	0.20	0.19
query19	1.97	1.89	2.02
query20	0.01	0.00	0.00
query21	15.37	0.61	0.59
query22	2.77	2.55	1.59
query23	17.09	0.92	0.89
query24	2.94	1.34	0.43
query25	0.27	0.16	0.08
query26	0.42	0.14	0.14
query27	0.04	0.04	0.03
query28	10.96	1.09	1.06
query29	12.56	3.18	3.23
query30	0.25	0.06	0.06
query31	2.89	0.38	0.38
query32	3.30	0.49	0.47
query33	2.95	3.02	3.03
query34	17.06	4.39	4.45
query35	4.57	4.49	4.51
query36	0.68	0.49	0.48
query37	0.08	0.05	0.05
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.12	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.67 s
Total hot run time: 32.04 s

@Mryange
Copy link
Contributor Author

Mryange commented Oct 6, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40885 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9f43076d1ac42a9b09b79409dece79a17912a45f, data reload: false

------ Round 1 ----------------------------------
q1	17707	7785	7277	7277
q2	2034	315	287	287
q3	12061	1081	1208	1081
q4	10580	798	748	748
q5	7732	2926	2896	2896
q6	236	147	151	147
q7	1032	634	607	607
q8	9379	1941	1987	1941
q9	6598	6471	6400	6400
q10	7009	2264	2364	2264
q11	432	243	243	243
q12	408	216	222	216
q13	17770	2952	3013	2952
q14	238	221	216	216
q15	589	524	538	524
q16	656	584	589	584
q17	971	562	546	546
q18	7439	6778	6754	6754
q19	1357	920	981	920
q20	483	214	201	201
q21	3918	3082	3195	3082
q22	1123	999	1002	999
Total cold run time: 109752 ms
Total hot run time: 40885 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7340	7289	7230	7230
q2	334	226	231	226
q3	3106	3001	2908	2908
q4	2078	1808	1852	1808
q5	5720	5786	5746	5746
q6	239	144	139	139
q7	2251	1854	1864	1854
q8	3428	3585	3446	3446
q9	8928	8867	8848	8848
q10	3594	3552	3535	3535
q11	586	489	487	487
q12	862	645	635	635
q13	9238	3205	3199	3199
q14	326	280	271	271
q15	575	535	518	518
q16	683	661	643	643
q17	1874	1624	1612	1612
q18	8329	7752	7460	7460
q19	1734	1470	1492	1470
q20	2141	1852	1859	1852
q21	5584	5432	5459	5432
q22	1155	1077	1057	1057
Total cold run time: 70105 ms
Total hot run time: 60376 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.31% (9628/25805)
Line Coverage: 28.69% (79840/278281)
Region Coverage: 28.14% (41290/146753)
Branch Coverage: 24.76% (21035/84970)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9f43076d1ac42a9b09b79409dece79a17912a45f_9f43076d1ac42a9b09b79409dece79a17912a45f/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 191237 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9f43076d1ac42a9b09b79409dece79a17912a45f, data reload: false

query1	871	406	391	391
query2	6263	2051	2008	2008
query3	8687	197	202	197
query4	33832	23391	23343	23343
query5	3514	449	451	449
query6	273	162	159	159
query7	4187	305	303	303
query8	285	219	228	219
query9	9303	2692	2692	2692
query10	462	294	292	292
query11	17828	15217	15174	15174
query12	153	97	97	97
query13	1550	442	416	416
query14	9463	7351	6977	6977
query15	257	166	166	166
query16	8013	456	477	456
query17	1582	610	580	580
query18	2158	336	313	313
query19	361	149	154	149
query20	121	117	118	117
query21	220	109	106	106
query22	4650	4493	4446	4446
query23	35443	33880	34359	33880
query24	11169	2902	2894	2894
query25	638	422	404	404
query26	1315	159	161	159
query27	2642	302	295	295
query28	7701	2455	2416	2416
query29	859	443	436	436
query30	261	151	155	151
query31	1041	802	803	802
query32	94	55	55	55
query33	780	285	301	285
query34	915	498	508	498
query35	873	723	721	721
query36	1095	941	942	941
query37	157	90	91	90
query38	4047	3957	3851	3851
query39	1475	1422	1452	1422
query40	258	97	99	97
query41	47	46	44	44
query42	112	96	97	96
query43	512	482	483	482
query44	1182	789	803	789
query45	198	165	162	162
query46	1169	712	716	712
query47	1960	1830	1853	1830
query48	441	361	346	346
query49	909	414	412	412
query50	843	416	412	412
query51	7150	6777	6977	6777
query52	102	86	86	86
query53	252	182	180	180
query54	1181	491	475	475
query55	80	79	80	79
query56	291	267	261	261
query57	1248	1157	1152	1152
query58	251	231	246	231
query59	3202	3013	3128	3013
query60	315	263	251	251
query61	102	104	103	103
query62	872	662	658	658
query63	224	184	181	181
query64	4533	651	623	623
query65	3257	3216	3219	3216
query66	1405	311	292	292
query67	16024	15584	15804	15584
query68	4323	564	547	547
query69	469	295	299	295
query70	1137	1133	1128	1128
query71	380	264	274	264
query72	7347	3964	4038	3964
query73	765	343	342	342
query74	10052	9025	9075	9025
query75	3422	2677	2686	2677
query76	3002	875	966	875
query77	577	300	290	290
query78	10733	9662	9557	9557
query79	1885	582	593	582
query80	2523	447	462	447
query81	597	237	236	236
query82	660	140	135	135
query83	301	150	133	133
query84	280	79	78	78
query85	1707	300	283	283
query86	442	297	276	276
query87	4464	4276	4274	4274
query88	3151	2445	2376	2376
query89	400	286	294	286
query90	2106	186	182	182
query91	141	108	107	107
query92	60	48	47	47
query93	1576	545	538	538
query94	1202	295	299	295
query95	348	250	249	249
query96	615	282	275	275
query97	3254	3086	3091	3086
query98	228	199	192	192
query99	1523	1302	1303	1302
Total cold run time: 302328 ms
Total hot run time: 191237 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.28 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9f43076d1ac42a9b09b79409dece79a17912a45f, data reload: false

query1	0.05	0.04	0.05
query2	0.06	0.03	0.02
query3	0.23	0.07	0.07
query4	1.65	0.11	0.10
query5	0.51	0.52	0.51
query6	1.12	0.72	0.72
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.56	0.50	0.49
query10	0.56	0.57	0.56
query11	0.13	0.09	0.10
query12	0.13	0.11	0.11
query13	0.61	0.60	0.61
query14	2.73	2.86	2.73
query15	0.89	0.80	0.82
query16	0.39	0.39	0.38
query17	1.01	1.06	1.05
query18	0.20	0.20	0.20
query19	1.94	1.78	2.01
query20	0.01	0.00	0.00
query21	15.38	0.59	0.58
query22	2.56	1.88	1.93
query23	16.90	0.95	0.89
query24	2.91	0.46	0.95
query25	0.21	0.19	0.10
query26	0.39	0.14	0.14
query27	0.03	0.04	0.04
query28	11.35	1.08	1.06
query29	12.60	3.20	3.20
query30	0.26	0.06	0.06
query31	2.88	0.39	0.37
query32	3.27	0.47	0.45
query33	2.99	3.04	3.04
query34	16.80	4.48	4.50
query35	4.47	4.48	4.55
query36	0.66	0.49	0.47
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 106.97 s
Total hot run time: 32.28 s

@Mryange Mryange changed the title [only test] [ubsan](PODArray)Avoid applying non-zero offset to null pointer Oct 7, 2024
@Mryange Mryange marked this pull request as ready for review October 7, 2024 02:11
@Mryange
Copy link
Contributor Author

Mryange commented Oct 7, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.32% (9630/25805)
Line Coverage: 28.71% (79887/278281)
Region Coverage: 28.14% (41291/146753)
Branch Coverage: 24.76% (21037/84970)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9f43076d1ac42a9b09b79409dece79a17912a45f_9f43076d1ac42a9b09b79409dece79a17912a45f/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 40536 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9f43076d1ac42a9b09b79409dece79a17912a45f, data reload: false

------ Round 1 ----------------------------------
q1	17570	7379	7252	7252
q2	2019	277	272	272
q3	12327	1062	1165	1062
q4	10584	825	744	744
q5	7772	2806	2772	2772
q6	236	149	146	146
q7	1001	648	637	637
q8	9374	1951	1954	1951
q9	6906	6436	6375	6375
q10	6973	2319	2295	2295
q11	442	248	246	246
q12	404	217	212	212
q13	17765	2999	2965	2965
q14	237	208	208	208
q15	574	518	513	513
q16	664	588	590	588
q17	981	493	531	493
q18	7184	6680	6551	6551
q19	1340	933	975	933
q20	475	197	199	197
q21	3950	3127	3254	3127
q22	1131	1003	997	997
Total cold run time: 109909 ms
Total hot run time: 40536 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7261	7475	7236	7236
q2	327	229	237	229
q3	3061	2947	2952	2947
q4	2070	1882	1758	1758
q5	5802	5749	5757	5749
q6	230	143	143	143
q7	2243	1815	1832	1815
q8	3322	3589	3477	3477
q9	8895	8948	8901	8901
q10	3595	3508	3541	3508
q11	568	480	509	480
q12	820	627	681	627
q13	11147	3160	3256	3160
q14	301	279	274	274
q15	583	542	525	525
q16	683	622	669	622
q17	1868	1658	1622	1622
q18	8294	7806	7566	7566
q19	1718	1415	1426	1415
q20	2109	1860	1915	1860
q21	5619	5562	5425	5425
q22	1146	1026	1050	1026
Total cold run time: 71662 ms
Total hot run time: 60365 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192764 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9f43076d1ac42a9b09b79409dece79a17912a45f, data reload: false

query1	957	399	412	399
query2	6264	2096	2020	2020
query3	8684	203	207	203
query4	33541	23811	23668	23668
query5	3544	486	454	454
query6	275	180	163	163
query7	4186	301	302	301
query8	280	235	217	217
query9	9381	2702	2710	2702
query10	457	282	300	282
query11	17642	15267	15191	15191
query12	149	100	99	99
query13	1574	458	452	452
query14	9779	7683	7720	7683
query15	252	171	188	171
query16	8025	471	511	471
query17	1632	653	604	604
query18	2161	325	340	325
query19	381	162	161	161
query20	118	117	116	116
query21	219	107	111	107
query22	4725	4466	4406	4406
query23	35077	34266	34173	34173
query24	10934	2899	2835	2835
query25	635	413	410	410
query26	1134	165	165	165
query27	2262	302	307	302
query28	7336	2457	2422	2422
query29	846	444	438	438
query30	279	156	157	156
query31	1011	779	817	779
query32	100	52	55	52
query33	767	318	314	314
query34	895	505	503	503
query35	894	736	749	736
query36	1116	971	980	971
query37	156	100	88	88
query38	4022	3811	3905	3811
query39	1467	1450	1419	1419
query40	220	98	101	98
query41	49	44	45	44
query42	112	97	96	96
query43	533	495	480	480
query44	1227	811	809	809
query45	200	168	167	167
query46	1154	718	738	718
query47	1916	1819	1823	1819
query48	438	353	338	338
query49	971	430	419	419
query50	843	437	418	418
query51	7083	6871	6917	6871
query52	102	88	85	85
query53	264	182	183	182
query54	1318	501	482	482
query55	83	78	74	74
query56	285	277	274	274
query57	1244	1159	1165	1159
query58	229	248	230	230
query59	3160	2891	3065	2891
query60	291	270	270	270
query61	110	103	102	102
query62	865	674	664	664
query63	222	187	180	180
query64	4067	643	618	618
query65	3359	3207	3210	3207
query66	1080	299	301	299
query67	15912	15661	15512	15512
query68	4660	574	551	551
query69	586	296	326	296
query70	1226	1142	1090	1090
query71	382	275	264	264
query72	7280	4071	4047	4047
query73	790	336	347	336
query74	10282	9048	8917	8917
query75	3537	2695	2703	2695
query76	3161	928	970	928
query77	446	311	287	287
query78	10382	9653	9528	9528
query79	1735	603	599	599
query80	2645	453	455	453
query81	585	244	239	239
query82	697	139	140	139
query83	295	136	136	136
query84	262	78	82	78
query85	1647	309	306	306
query86	442	268	301	268
query87	4398	4328	4336	4328
query88	3879	2464	2416	2416
query89	400	289	289	289
query90	2135	189	189	189
query91	153	106	112	106
query92	65	50	50	50
query93	1460	547	547	547
query94	1230	295	304	295
query95	358	255	256	255
query96	618	281	286	281
query97	3249	3107	3082	3082
query98	216	201	191	191
query99	1526	1304	1303	1303
Total cold run time: 301221 ms
Total hot run time: 192764 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.11 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9f43076d1ac42a9b09b79409dece79a17912a45f, data reload: false

query1	0.05	0.04	0.04
query2	0.07	0.03	0.03
query3	0.22	0.06	0.06
query4	1.65	0.10	0.10
query5	0.52	0.51	0.51
query6	1.13	0.73	0.72
query7	0.03	0.01	0.02
query8	0.04	0.03	0.03
query9	0.55	0.49	0.48
query10	0.54	0.57	0.57
query11	0.14	0.11	0.11
query12	0.14	0.11	0.10
query13	0.61	0.60	0.59
query14	2.71	2.74	2.78
query15	0.91	0.85	0.83
query16	0.36	0.38	0.39
query17	1.03	1.01	1.03
query18	0.20	0.20	0.20
query19	1.95	1.76	1.88
query20	0.01	0.01	0.01
query21	15.36	0.58	0.59
query22	2.80	2.38	1.65
query23	16.98	1.02	0.86
query24	2.90	0.48	1.47
query25	0.15	0.19	0.17
query26	0.36	0.14	0.13
query27	0.04	0.04	0.04
query28	10.99	1.10	1.07
query29	12.57	3.24	3.22
query30	0.24	0.06	0.05
query31	2.87	0.38	0.38
query32	3.28	0.47	0.46
query33	3.01	3.02	3.07
query34	16.87	4.44	4.48
query35	4.50	4.57	4.50
query36	0.66	0.48	0.48
query37	0.08	0.06	0.06
query38	0.05	0.03	0.04
query39	0.03	0.04	0.02
query40	0.15	0.12	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.91 s
Total hot run time: 32.11 s

HappenLee
HappenLee approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

PR approved by anyone and no changes requested.

@HappenLee HappenLee merged commit 4602068 into apache:master Oct 9, 2024
26 of 31 checks passed
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Oct 10, 2024
@Mryange @eldenmoon
[ubsan](PODArray)Avoid applying non-zero offset to null pointer (apac…
322e529 
…he#41525)

The original code would generate a null c_end when there is no padding.
before
```
    static constexpr char* null =
            pad_left ? const_cast<char*>(empty_pod_array) + EmptyPODArraySize : nullptr;
```
now
```
    static constexpr char* null = const_cast<char*>(empty_pod_array) + pad_left;
```
cjj2010 pushed a commit to cjj2010/doris that referenced this pull request Oct 12, 2024
@Mryange @cjj2010
[ubsan](PODArray)Avoid applying non-zero offset to null pointer (apac…
d117c35 
…he#41525)

The original code would generate a null c_end when there is no padding.
before
```
    static constexpr char* null =
            pad_left ? const_cast<char*>(empty_pod_array) + EmptyPODArraySize : nullptr;
```
now
```
    static constexpr char* null = const_cast<char*>(empty_pod_array) + pad_left;
```
amorynan pushed a commit to amorynan/doris that referenced this pull request Oct 12, 2024
@Mryange @amorynan
[ubsan](PODArray)Avoid applying non-zero offset to null pointer (apac…
06ea1be 
…he#41525)

The original code would generate a null c_end when there is no padding.
before
```
    static constexpr char* null =
            pad_left ? const_cast<char*>(empty_pod_array) + EmptyPODArraySize : nullptr;
```
now
```
    static constexpr char* null = const_cast<char*>(empty_pod_array) + pad_left;
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HappenLee HappenLee HappenLee approved these changes

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mryange @doris-robot @BiteTheDDDDt @HappenLee