Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cloud](Variant) limit column size in MetaService and support handle rowset schema in backend side #41482

Merged
merged 2 commits into from
Nov 1, 2024
Merged

[cloud](Variant) limit column size in MetaService and support handle rowset schema in backend side #41482

merged 2 commits into from
Nov 1, 2024

Conversation

eldenmoon
Copy link
Member

@eldenmoon eldenmoon commented Sep 29, 2024 •
edited
Loading

  1. in local mode we limit column size in commit_txn phase, in cloud mode we limit it in write_schema_dict which in commit_rowset phase
  2. add config to decide whether fill schema in BE side or MS side

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@eldenmoon
Copy link
Member Author

run buildall

@eldenmoon
Copy link
Member Author

run buildall

@wm1581066 wm1581066 requested a review from gavinchou September 30, 2024 02:07
@wm1581066 wm1581066 added the usercase Important user case type label label Sep 30, 2024
gavinchou
gavinchou requested changes Oct 1, 2024
View reviewed changes
cloud/src/common/config.h Outdated Show resolved Hide resolved
@eldenmoon
[cloud](Variant) limit column size in MetaService
acda4df 
in local mode we limit column size in commit_txn phase, in cloud mode we limit it in `write_schema_dict` which in commit_rowset phase
@eldenmoon eldenmoon force-pushed the cloud-lm-ar branch 2 times, most recently from b1f8c04 to acda4df Compare October 11, 2024 07:11
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@eldenmoon
Copy link
Member Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.48% (9708/25903)
Line Coverage: 28.76% (80650/280471)
Region Coverage: 28.19% (41730/148016)
Branch Coverage: 24.77% (21214/85650)
Coverage Report: http://coverage.selectdb-in.cc/coverage/366aa9d61e917e19e0bc1d478018ec51553aaa01_366aa9d61e917e19e0bc1d478018ec51553aaa01/report/index.html

@eldenmoon
Copy link
Member Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@eldenmoon eldenmoon requested a review from gavinchou October 22, 2024 13:35
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.47% (9708/25911)
Line Coverage: 28.73% (80534/280308)
Region Coverage: 28.15% (41638/147916)
Branch Coverage: 24.72% (21156/85578)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9ee812c2b11891b938ea73e548b998cafd85d9e8_9ee812c2b11891b938ea73e548b998cafd85d9e8/report/index.html

@eldenmoon eldenmoon changed the title [cloud](Variant) limit column size in MetaService [cloud](Variant) limit column size in MetaService and support handle rowset schema in backend side Oct 23, 2024
@gavinchou
Copy link
Contributor

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

xiaokang
xiaokang approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaokang xiaokang merged commit 2092b44 into apache:master Nov 1, 2024
32 of 40 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 1, 2024
@eldenmoon
[cloud](Variant) limit column size in MetaService and support handle …
f85ade1 
…rowset schema in backend side (#41482)

1. in local mode we limit column size in commit_txn phase, in cloud mode
we limit it in `write_schema_dict` which in commit_rowset phase
2. add config to decide whether fill schema in BE side or MS side
@github-actions github-actions bot mentioned this pull request Nov 1, 2024
Merged
@eldenmoon eldenmoon deleted the cloud-lm-ar branch November 4, 2024 02:11
eldenmoon pushed a commit that referenced this pull request Nov 5, 2024
@github-actions
[cloud](Variant) limit column size in MetaService and support handle …
d9f270a 
…rowset schema in backend side(#41482) (#43093)

PR Body: 1. in local mode we limit column size in commit_txn phase, in
cloud mode we limit it in `write_schema_dict` which in commit_rowset
phase
2. add config to decide whether fill schema in BE side or MS side

 
 Cherry-picked from #41482
@gavinchou gavinchou added the cir label Nov 11, 2024
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinchou gavinchou gavinchou approved these changes

@xiaokang xiaokang xiaokang approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. cir dev/3.0.3-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eldenmoon @doris-robot @gavinchou @xiaokang @wm1581066