Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat](profile) Print changed session var in profile #41016

Merged
merged 15 commits into from
Sep 23, 2024

Conversation

zhiqiang-hhhh
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh commented Sep 19, 2024

Add changed session var like follow:

Changed Session Variables:
VarName                                         | CurrentValue        | DefaultValue
------------------------------------------------|---------------------|-------------
character_set_results                           | NULL                | utf8mb4
enable_profile                                  | true                | false
enable_auto_analyze                             | false               | true
max_scan_key_num                                | -1                  | 48
enable_prepared_stmt_audit_log                  | true                | false
sql_mode                                        | STRICT_TRANS_TABLES |
wait_timeout                                    | 31000               | 28800
parallel_pipeline_task_num                      | 8                   | 0
num_scanner_threads                             | 10                  | 0
experimental_enable_agg_state                   | true                | false
max_pushdown_conditions_per_column              | -1                  | 1024
experimental_parallel_scan_min_rows_per_scanner | 16384               | 2097152
max_allowed_packet                              | 1048576             | 16777216

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhiqiang-hhhh zhiqiang-hhhh force-pushed the feat-profile-session-var branch from db2164b to 56d54b9 Compare September 19, 2024 12:12
@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

1 similar comment
@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@zhiqiang-hhhh zhiqiang-hhhh marked this pull request as ready for review September 19, 2024 13:20
@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

public void getExecutionProfileContent(StringBuilder builder) {
if (builder == null) {
builder = new StringBuilder();
}

if (profileHasBeenStored()) {
LOG.info("Profile {} has been stored to storage, reading it from storage", id);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么改这个?

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 23, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 7c9c0e0 into apache:master Sep 23, 2024
27 of 30 checks passed
@zhiqiang-hhhh zhiqiang-hhhh deleted the feat-profile-session-var branch September 23, 2024 07:07
zhiqiang-hhhh added a commit to zhiqiang-hhhh/doris that referenced this pull request Sep 25, 2024
Add changed session var like follow:
```
Changed Session Variables:
VarName                                         | CurrentValue        | DefaultValue
------------------------------------------------|---------------------|-------------
character_set_results                           | NULL                | utf8mb4
enable_profile                                  | true                | false
enable_auto_analyze                             | false               | true
max_scan_key_num                                | -1                  | 48
enable_prepared_stmt_audit_log                  | true                | false
sql_mode                                        | STRICT_TRANS_TABLES |
wait_timeout                                    | 31000               | 28800
parallel_pipeline_task_num                      | 8                   | 0
num_scanner_threads                             | 10                  | 0
experimental_enable_agg_state                   | true                | false
max_pushdown_conditions_per_column              | -1                  | 1024
experimental_parallel_scan_min_rows_per_scanner | 16384               | 2097152
max_allowed_packet                              | 1048576             | 16777216
```
zhiqiang-hhhh added a commit to zhiqiang-hhhh/doris that referenced this pull request Sep 25, 2024
Add changed session var like follow:
```
Changed Session Variables:
VarName                                         | CurrentValue        | DefaultValue
------------------------------------------------|---------------------|-------------
character_set_results                           | NULL                | utf8mb4
enable_profile                                  | true                | false
enable_auto_analyze                             | false               | true
max_scan_key_num                                | -1                  | 48
enable_prepared_stmt_audit_log                  | true                | false
sql_mode                                        | STRICT_TRANS_TABLES |
wait_timeout                                    | 31000               | 28800
parallel_pipeline_task_num                      | 8                   | 0
num_scanner_threads                             | 10                  | 0
experimental_enable_agg_state                   | true                | false
max_pushdown_conditions_per_column              | -1                  | 1024
experimental_parallel_scan_min_rows_per_scanner | 16384               | 2097152
max_allowed_packet                              | 1048576             | 16777216
```
yiguolei pushed a commit that referenced this pull request Sep 27, 2024
zhiqiang-hhhh added a commit to zhiqiang-hhhh/doris that referenced this pull request Sep 27, 2024
Add changed session var like follow:
```
Changed Session Variables:
VarName                                         | CurrentValue        | DefaultValue
------------------------------------------------|---------------------|-------------
character_set_results                           | NULL                | utf8mb4
enable_profile                                  | true                | false
enable_auto_analyze                             | false               | true
max_scan_key_num                                | -1                  | 48
enable_prepared_stmt_audit_log                  | true                | false
sql_mode                                        | STRICT_TRANS_TABLES |
wait_timeout                                    | 31000               | 28800
parallel_pipeline_task_num                      | 8                   | 0
num_scanner_threads                             | 10                  | 0
experimental_enable_agg_state                   | true                | false
max_pushdown_conditions_per_column              | -1                  | 1024
experimental_parallel_scan_min_rows_per_scanner | 16384               | 2097152
max_allowed_packet                              | 1048576             | 16777216
```
yiguolei pushed a commit that referenced this pull request Oct 18, 2024
@yiguolei yiguolei mentioned this pull request Nov 6, 2024
@yiguolei yiguolei mentioned this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants