[feature](array-func)support array_match_all/any #40605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
TeamCity be ut coverage result: |
morrySnow
reviewed
Sep 10, 2024
fe/fe-core/src/main/java/org/apache/doris/catalog/BuiltinScalarFunctions.java
Show resolved
Hide resolved
...src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ArrayMatchAll.java
Outdated
Show resolved
Hide resolved
Comment on lines
44
to
46
| private ArrayMatchAll(List<Expression> expressions) { | ||
| super("array_match_all", expressions); | ||
| } |
...src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ArrayMatchAll.java
Outdated
Show resolved
Hide resolved
Comment on lines
53
to
57
| super("array_match_all", arg instanceof Lambda ? arg.child(1).child(0) : arg, new ArrayMap(arg)); | ||
| if (!(arg instanceof Lambda)) { | ||
| throw new AnalysisException( | ||
| String.format("The 1st arg of %s must be lambda but is %s", getName(), arg)); | ||
| } |
There was a problem hiding this comment.
Suggested change
| super("array_match_all", arg instanceof Lambda ? arg.child(1).child(0) : arg, new ArrayMap(arg)); | |
| if (!(arg instanceof Lambda)) { | |
| throw new AnalysisException( | |
| String.format("The 1st arg of %s must be lambda but is %s", getName(), arg)); | |
| } | |
| super("array_match_all", arg instanceof Lambda ? new ArrayMap(arg) : arg); |
...src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ArrayMatchAll.java
Show resolved
Hide resolved
TPC-H: Total hot run time: 38163 ms |
TPC-DS: Total hot run time: 197908 ms |
ClickBench: Total hot run time: 31.52 s |
eldenmoon
reviewed
Sep 11, 2024
eldenmoon
reviewed
Sep 11, 2024
| if (first_outside_null_map->get_data()[row] || | ||
| second_outside_null_map->get_data()[row]) { | ||
| result_null_column->get_data()[row] = 1; | ||
| result_data_column->get_data()[row] = 0; |
There was a problem hiding this comment.
better add comment to explain why return null instead of false, and need to describe the behavior in document
eldenmoon
reviewed
Sep 11, 2024
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
eldenmoon
reviewed
Sep 11, 2024
| @@ -0,0 +1,68 @@ | |||
| // Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
add document and link to this PR
There was a problem hiding this comment.
we need to detail explain the behavior if encounter null in arrays for the two functions, it's confusing
TPC-H: Total hot run time: 38190 ms |
TPC-DS: Total hot run time: 197140 ms |
ClickBench: Total hot run time: 31.29 s |
eldenmoon
reviewed
Sep 11, 2024
morrySnow
reviewed
Sep 11, 2024
.../src/main/java/org/apache/doris/nereids/trees/expressions/visitor/ScalarFunctionVisitor.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/catalog/BuiltinScalarFunctions.java
Outdated
Show resolved
Hide resolved
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38521 ms |
TPC-DS: Total hot run time: 198173 ms |
|
we need to detail explain the behavior if encounter null in arrays for the two functions, it's confusing |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
ClickBench: Total hot run time: 32.02 s |
|
run cloud_p0 |
morrySnow
approved these changes
Sep 12, 2024
amorynan
added a commit
to amorynan/doris
that referenced
this pull request
Nov 8, 2024
array_match_all means that every element in array column should all match filter according to lambda expr array_match_any means that any element in array column match filter according to lambda expr
airborne12
pushed a commit
that referenced
this pull request
Nov 9, 2024
array_match_all
means that every element in array column should all match filter
according to lambda expr
array_match_any
means that any element in array column match filter according to lambda
expr
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
### Check List (For Reviewer who merge this PR)
- [x] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
array_match_all
means that every element in array column should all match filter according to lambda expr
array_match_any
means that any element in array column match filter according to lambda expr
Issue Number: close #xxx